linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Cameron <jonathan.cameron@huawei.com>
To: <jic23@kernel.org>
Cc: <linux-iio@vger.kernel.org>,
	Daniel Baluta <daniel.baluta@gmail.com>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Hartmut Knaack <knaack.h@gmx.de>,
	"Peter Meerwald-Stadler" <pmeerw@pmeerw.net>
Subject: Re: [PATCH 00/14] iio: SPDX headers for core + non device driver parts.
Date: Wed, 17 Jul 2019 17:07:27 +0100	[thread overview]
Message-ID: <20190717170727.00001363@huawei.com> (raw)
In-Reply-To: <20190622145516.3231-1-jic23@kernel.org>

If anyone has time to sanity check these, it would be much appreciated.

At somepoint I'll take a view on them being too dull to garner review, but
I really don't like applying stuff that hasn't had a second set of eyes on it.

Thanks,

Jonathan

On Sat, 22 Jun 2019 15:55:02 +0100
<jic23@kernel.org> wrote:

> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> 
> There is a general movement towards ensuring all of the kernel source
> files have SPDX headers.  I have previously expressed the view, that,
> like many cleanups it would be better to do these when otherwise touching
> the relevant part of the code, rather than creating noise throughout.
> 
> Time to change my mind on that, and push through adding these to IIO.
> 
> Even in the core code, I was less than entirely consistent with the
> existing license markings, so there are places where the file headers
> don't match with the MODULE_LICENSE macro.
> There were also headers that gained default SPDX license markings
> that actually aren't quite correct given the related c files sometimes
> did have well stated licenses.
> 
> If someone has time to check my logic on the these that would be great.
> 
> For the drivers, my intent is to use random periods of boredom
> (I'm on some long haul flights in the near future) to see if I can
> plough through them.  If anyone wants to get ahead of the game and
> do their own drivers that would be great.  This is particularly true
> in the big octopus drivers that spread throughout the IIO directories
> and beyond.  I'd love it if other people took those on.
> 
> If in doubt, don't do a given file or put out a clearly worded email
> to the list asking for help!
> 
> Jonathan Cameron (14):
>   iio: core: SPDX headers for core files. Note fix to MODULE_LICENSE
>   iio:configfs: SPDX headers.
>   iio: sw-device: SPDX headers
>   iio: sw-trigger: SPDX headers.
>   iio: triggered-event: Add SPDX and fix header license to match the
>     code.
>   iio:buffer-dma: SPDX headers.
>   iio: buffer-cb: SPDX headers
>   iio: kfifo-buf: Add SPDX header
>   iio: buffer-dmaengine: SPDX GPL-2.0+
>   iio: triggered-buffer: SPDX + fix MODULE_LICENSE to GPLv2
>   iio: trig-hrtimer: SPDX header GPLv2
>   iio: trig-interrupt: SPDX headers. GPLv2
>   iio: trig-loop: SPDX headers GPL-v2
>   iio: trig-sysfs: SPDX headers GPLv2.
> 
>  drivers/iio/buffer/industrialio-buffer-cb.c        |  8 +++-----
>  drivers/iio/buffer/industrialio-buffer-dma.c       |  3 +--
>  drivers/iio/buffer/industrialio-buffer-dmaengine.c |  3 +--
>  drivers/iio/buffer/industrialio-triggered-buffer.c |  9 +++------
>  drivers/iio/buffer/kfifo_buf.c                     |  1 +
>  drivers/iio/iio_core.h                             |  8 +++-----
>  drivers/iio/iio_core_trigger.h                     |  2 +-
>  drivers/iio/industrialio-buffer.c                  |  8 +++-----
>  drivers/iio/industrialio-configfs.c                |  5 +----
>  drivers/iio/industrialio-core.c                    | 10 ++++------
>  drivers/iio/industrialio-event.c                   |  4 +++-
>  drivers/iio/industrialio-sw-device.c               |  5 +----
>  drivers/iio/industrialio-sw-trigger.c              |  5 +----
>  drivers/iio/industrialio-trigger.c                 |  8 +++-----
>  drivers/iio/industrialio-triggered-event.c         |  6 +-----
>  drivers/iio/inkern.c                               |  8 +++-----
>  drivers/iio/trigger/iio-trig-hrtimer.c             |  6 +-----
>  drivers/iio/trigger/iio-trig-interrupt.c           |  5 +----
>  drivers/iio/trigger/iio-trig-loop.c                |  3 +--
>  drivers/iio/trigger/iio-trig-sysfs.c               |  4 +---
>  include/linux/iio/buffer-dma.h                     |  3 +--
>  include/linux/iio/buffer-dmaengine.h               |  3 +--
>  include/linux/iio/buffer.h                         |  8 +++-----
>  include/linux/iio/configfs.h                       |  5 +----
>  include/linux/iio/consumer.h                       |  5 +----
>  include/linux/iio/driver.h                         |  5 +----
>  include/linux/iio/events.h                         |  8 +++-----
>  include/linux/iio/iio.h                            |  9 +++------
>  include/linux/iio/kfifo_buf.h                      |  2 +-
>  include/linux/iio/machine.h                        |  5 +----
>  include/linux/iio/sw_device.h                      |  5 +----
>  include/linux/iio/sw_trigger.h                     |  5 +----
>  include/linux/iio/sysfs.h                          | 10 ++++------
>  include/linux/iio/trigger.h                        |  5 +----
>  include/linux/iio/trigger_consumer.h               |  8 +++-----
>  include/linux/iio/triggered_event.h                |  2 +-
>  include/linux/iio/types.h                          |  8 +++-----
>  37 files changed, 67 insertions(+), 140 deletions(-)
> 



  parent reply	other threads:[~2019-07-17 16:07 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-22 14:55 [PATCH 00/14] iio: SPDX headers for core + non device driver parts jic23
2019-06-22 14:55 ` [PATCH 01/14] iio: core: SPDX headers for core files. Note fix to MODULE_LICENSE jic23
2019-06-22 14:55 ` [PATCH 02/14] iio:configfs: SPDX headers jic23
2019-06-22 14:55 ` [PATCH 03/14] iio: sw-device: " jic23
2019-06-22 14:55 ` [PATCH 04/14] iio: sw-trigger: " jic23
2019-06-22 14:55 ` [PATCH 05/14] iio: triggered-event: Add SPDX and fix header license to match the code jic23
2019-06-22 14:55 ` [PATCH 06/14] iio:buffer-dma: SPDX headers jic23
2019-06-22 14:55 ` [PATCH 07/14] iio: buffer-cb: " jic23
2019-06-22 14:55 ` [PATCH 08/14] iio: kfifo-buf: Add SPDX header jic23
2019-06-22 14:55 ` [PATCH 09/14] iio: buffer-dmaengine: SPDX GPL-2.0+ jic23
2019-06-22 14:55 ` [PATCH 10/14] iio: triggered-buffer: SPDX + fix MODULE_LICENSE to GPLv2 jic23
2019-06-22 14:55 ` [PATCH 11/14] iio: trig-hrtimer: SPDX header GPLv2 jic23
2019-06-22 14:55 ` [PATCH 12/14] iio: trig-interrupt: SPDX headers. GPLv2 jic23
2019-06-22 14:55 ` [PATCH 13/14] iio: trig-loop: SPDX headers GPL-v2 jic23
2019-07-17 17:58   ` Himanshu Jha
2019-07-17 21:12     ` Greg KH
2019-08-17 19:08       ` J Lovejoy
2019-08-17 20:38         ` Greg KH
2019-06-22 14:55 ` [PATCH 14/14] iio: trig-sysfs: SPDX headers GPLv2 jic23
2019-07-17 16:07 ` Jonathan Cameron [this message]
2019-07-18  8:36   ` [PATCH 00/14] iio: SPDX headers for core + non device driver parts Ardelean, Alexandru
2019-07-21 17:04     ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190717170727.00001363@huawei.com \
    --to=jonathan.cameron@huawei.com \
    --cc=daniel.baluta@gmail.com \
    --cc=jic23@kernel.org \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=pmeerw@pmeerw.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).