From: William Breathitt Gray <vilhelm.gray@gmail.com>
To: David Lechner <david@lechnology.com>
Cc: linux-iio@vger.kernel.org, linux-omap@vger.kernel.org,
"Rob Herring" <robh+dt@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"Benoît Cousson" <bcousson@baylibre.com>,
"Tony Lindgren" <tony@atomide.com>,
"Thierry Reding" <thierry.reding@gmail.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pwm@vger.kernel.org, "Jonathan Cameron" <jic23@kernel.org>
Subject: Re: [PATCH v2 3/5] counter: new TI eQEP driver
Date: Thu, 15 Aug 2019 21:37:58 +0900 [thread overview]
Message-ID: <20190815123758.GA646493@icarus> (raw)
In-Reply-To: <20190807194023.15318-4-david@lechnology.com>
On Wed, Aug 07, 2019 at 02:40:21PM -0500, David Lechner wrote:
> +static struct counter_synapse ti_eqep_position_synapses[] = {
> + {
> + .action = TI_EQEP_SYNAPSE_ACTION_BOTH_EDGES,
> + .actions_list = ti_eqep_position_synapse_actions,
> + .num_actions = ARRAY_SIZE(ti_eqep_position_synapse_actions),
> + .signal = &ti_eqep_signals[TI_EQEP_SIGNAL_QEPA],
> + },
> + {
> + .action = TI_EQEP_SYNAPSE_ACTION_BOTH_EDGES,
> + .actions_list = ti_eqep_position_synapse_actions,
> + .num_actions = ARRAY_SIZE(ti_eqep_position_synapse_actions),
> + .signal = &ti_eqep_signals[TI_EQEP_SIGNAL_QEPB],
> + },
> +};
Hi David,
Just a minor suggestion for your v3: you don't need to initialize
"action" here since it'll be automatically updated in the core
counter_action_show function to the value returned by your action_get
callback function. So you can safely delete those two ".action =" lines.
William Breathitt Gray
next prev parent reply other threads:[~2019-08-15 12:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-07 19:40 [PATCH v2 0/5] counter: new TI eQEP driver David Lechner
2019-08-07 19:40 ` [PATCH v2 1/5] bus/ti-pwmss: move TI PWMSS driver from PWM to bus subsystem David Lechner
2019-08-07 19:40 ` [PATCH v2 2/5] dt-bindings: counter: new bindings for TI eQEP David Lechner
2019-08-21 20:31 ` Rob Herring
2019-08-07 19:40 ` [PATCH v2 3/5] counter: new TI eQEP driver David Lechner
2019-08-07 19:49 ` David Lechner
2019-08-11 9:23 ` Jonathan Cameron
2019-08-11 19:15 ` David Lechner
2019-08-15 12:37 ` William Breathitt Gray [this message]
2019-08-07 19:40 ` [PATCH v2 4/5] ARM: dts: am33xx: Add nodes for eQEP David Lechner
2019-08-07 19:40 ` [PATCH v2 5/5] ARM: dts: am335x-boneblue: Enable eQEP David Lechner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190815123758.GA646493@icarus \
--to=vilhelm.gray@gmail.com \
--cc=bcousson@baylibre.com \
--cc=david@lechnology.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).