From: Jonathan Cameron <jic23@kernel.org>
To: Colin King <colin.king@canonical.com>
Cc: Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Martyn Welch <martyn.welch@collabora.com>,
Sergei M <fizik1@yandex.com>,
linux-iio@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][iio-next] iio: light: noa1305: fix missing break in a switch statement
Date: Sun, 18 Aug 2019 18:14:44 +0100 [thread overview]
Message-ID: <20190818181444.55fc35b3@archlinux> (raw)
In-Reply-To: <20190815074339.32380-1-colin.king@canonical.com>
On Thu, 15 Aug 2019 08:43:39 +0100
Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> There is a missing break for the NOA1305_INTEGR_TIME_400MS case,
> fix it by adding it in.
>
> Addresses-Coverity: ("Missing break in switch")
> Fixes: 741172d18e8a ("iio: light: noa1305: Add support for NOA1305")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Hi Colin
Fix already on it's way in. Was also caught by 0-day.
Thanks,
Jonathan
> ---
> drivers/iio/light/noa1305.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iio/light/noa1305.c b/drivers/iio/light/noa1305.c
> index 7b859ae1044d..5ebfbc52f541 100644
> --- a/drivers/iio/light/noa1305.c
> +++ b/drivers/iio/light/noa1305.c
> @@ -85,6 +85,7 @@ static int noa1305_scale(struct noa1305_priv *priv, int *val, int *val2)
> case NOA1305_INTEGR_TIME_400MS:
> *val = 100;
> *val2 = 77 * 4;
> + break;
> case NOA1305_INTEGR_TIME_200MS:
> *val = 100;
> *val2 = 77 * 2;
prev parent reply other threads:[~2019-08-18 17:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-15 7:43 [PATCH][iio-next] iio: light: noa1305: fix missing break in a switch statement Colin King
2019-08-18 17:14 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190818181444.55fc35b3@archlinux \
--to=jic23@kernel.org \
--cc=colin.king@canonical.com \
--cc=fizik1@yandex.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martyn.welch@collabora.com \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).