From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Jonathan Cameron <jic23@kernel.org>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Alexios Zavras <alexios.zavras@intel.com>,
Colin Ian King <colin.king@canonical.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [RFC] Revert "iio: hid-sensor-attributes: Convert to use int_pow()"
Date: Fri, 6 Sep 2019 19:55:27 +0300 [thread overview]
Message-ID: <20190906165527.GW2680@smile.fi.intel.com> (raw)
In-Reply-To: <20190906154609.2421410-1-arnd@arndb.de>
On Fri, Sep 06, 2019 at 05:45:55PM +0200, Arnd Bergmann wrote:
> The change to use the generic int_pow instead of the private version
> caused a number of build issues on 32-bit architectures and makes
> it generally less efficient because of the 64-bit math:
>
> drivers/iio/common/hid-sensors/hid-sensor-attributes.o: In function `hid_sensor_write_samp_freq_value':
> hid-sensor-attributes.c:(.text+0x29c): undefined reference to `__aeabi_uldivmod'
> drivers/iio/common/hid-sensors/hid-sensor-attributes.o: In function `hid_sensor_read_raw_hyst_value':
> hid-sensor-attributes.c:(.text+0x420): undefined reference to `__aeabi_uldivmod'
> hid-sensor-attributes.c:(.text+0x448): undefined reference to `__aeabi_uldivmod'
> drivers/iio/common/hid-sensors/hid-sensor-attributes.o: In function `hid_sensor_write_raw_hyst_value':
> hid-sensor-attributes.c:(.text+0x570): undefined reference to `__aeabi_uldivmod'
>
> There is probably a nicer solution to this, but for the moment,
> the revert makes it compile again.
>
> Fixes: 473d12f7638c ("iio: hid-sensor-attributes: Convert to use int_pow()")
Does the fix [1] works for you?
[1]: https://lore.kernel.org/linux-iio/6851830d050ddb2f27d1e6969755ee4f3293d37c.camel@intel.com/
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2019-09-06 16:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-06 15:45 [PATCH] [RFC] Revert "iio: hid-sensor-attributes: Convert to use int_pow()" Arnd Bergmann
2019-09-06 16:55 ` Andy Shevchenko [this message]
2019-09-06 18:46 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190906165527.GW2680@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=alexios.zavras@intel.com \
--cc=arnd@arndb.de \
--cc=colin.king@canonical.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).