From: Jonathan Cameron <jic23@kernel.org>
To: Krzysztof Wilczynski <kw@linux.com>
Cc: "Hartmut Knaack" <knaack.h@gmx.de>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Peter Meerwald-Stadler" <pmeerw@pmeerw.net>,
"Tomasz Duszynski" <tduszyns@gmail.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
linux-iio@vger.kernel.org
Subject: Re: [PATCH v3] iio: light: bh1750: Resolve compiler warning and make code more readable
Date: Sun, 15 Sep 2019 10:48:38 +0100 [thread overview]
Message-ID: <20190915104838.0776d2a4@archlinux> (raw)
In-Reply-To: <20190913202413.3034-1-kw@linux.com>
On Fri, 13 Sep 2019 22:24:13 +0200
Krzysztof Wilczynski <kw@linux.com> wrote:
> Separate the declaration of struct bh1750_chip_info from definition
> of bh1750_chip_info_tbl[] in a single statement as it makes the code
> hard to read, and with the extra newline it makes it look as if the
> bh1750_chip_info_tbl[] had no explicit type.
>
> This change also resolves the following compiler warning about the
> unusual position of the static keyword that can be seen when building
> with warnings enabled (W=1):
>
> drivers/iio/light/bh1750.c:64:1: warning:
> ‘static’ is not at beginning of declaration [-Wold-style-declaration]
>
> Related to commit 3a11fbb037a1 ("iio: light: add support for ROHM
> BH1710/BH1715/BH1721/BH1750/BH1751 ambient light sensors").
>
> Signed-off-by: Krzysztof Wilczynski <kw@linux.com>
Applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to play with it. Added Uwe's Acked-by as well.
Sorry for the confusing advice I gave earlier, I managed to confuse
myself on what the original code said.
Jonathan
> ---
> Changes in v3:
> Updated wording of the commit message as per the review feedback.
>
> Changes in v2:
> Made definition of bh1750_chip_info_tbl separate from declaration
> as per the review feedback. This also makes the code more readable.
> Updated wording of the subject and the commit message.
>
> drivers/iio/light/bh1750.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/light/bh1750.c b/drivers/iio/light/bh1750.c
> index 28347df78cff..adb5ab9e3439 100644
> --- a/drivers/iio/light/bh1750.c
> +++ b/drivers/iio/light/bh1750.c
> @@ -59,9 +59,9 @@ struct bh1750_chip_info {
>
> u16 int_time_low_mask;
> u16 int_time_high_mask;
> -}
> +};
>
> -static const bh1750_chip_info_tbl[] = {
> +static const struct bh1750_chip_info bh1750_chip_info_tbl[] = {
> [BH1710] = { 140, 1022, 300, 400, 250000000, 2, 0x001F, 0x03E0 },
> [BH1721] = { 140, 1020, 300, 400, 250000000, 2, 0x0010, 0x03E0 },
> [BH1750] = { 31, 254, 69, 1740, 57500000, 1, 0x001F, 0x00E0 },
next prev parent reply other threads:[~2019-09-15 9:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-02 11:31 [PATCH] iio: light: bh1750: Move static keyword to the front of declaration Krzysztof Wilczynski
2019-09-03 17:35 ` Tomasz Duszynski
2019-09-08 10:49 ` Jonathan Cameron
2019-09-08 13:52 ` Krzysztof Wilczynski
2019-09-10 13:35 ` Jonathan Cameron
2019-09-10 20:25 ` Krzysztof Wilczynski
2019-09-10 20:38 ` [PATCH v2] iio: light: bh1750: Resolve compiler warning and make code more readable Krzysztof Wilczynski
2019-09-10 21:04 ` Uwe Kleine-König
2019-09-13 20:24 ` [PATCH v3] " Krzysztof Wilczynski
2019-09-15 9:48 ` Jonathan Cameron [this message]
2019-09-15 18:41 ` Krzysztof Wilczynski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190915104838.0776d2a4@archlinux \
--to=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=kw@linux.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=tduszyns@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).