From: Jonathan Cameron <jic23@kernel.org>
To: Sean Nyekjaer <sean@geanix.com>
Cc: linux-iio@vger.kernel.org, lorenzo.bianconi83@gmail.com,
denis.ciocca@st.com, mario.tesi@st.com, armando.visconti@st.com,
martin@geanix.com
Subject: Re: [PATCH v10 4/5] iio: imu: st_lsm6dsx: always enter interrupt thread
Date: Sat, 5 Oct 2019 12:37:32 +0100 [thread overview]
Message-ID: <20191005123732.5483c773@archlinux> (raw)
In-Reply-To: <20190916135630.2211714-4-sean@geanix.com>
On Mon, 16 Sep 2019 15:56:29 +0200
Sean Nyekjaer <sean@geanix.com> wrote:
> The interrupt source can come from multiple sources,
> fifo and wake interrupts.
> Enter interrupt thread to check which interrupt that has fired.
>
> Signed-off-by: Sean Nyekjaer <sean@geanix.com>
Applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to play with it.
thanks,
Jonathan
> ---
> Changes since v8:
> * Remove st_lsm6dsx_handler_irq function to enter interrupt thread
> at every interrupt
>
> Changes since v9:
> * None
>
> drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c | 9 +--------
> 1 file changed, 1 insertion(+), 8 deletions(-)
>
> diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
> index a7f12cf57f11..6b03c50f4732 100644
> --- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
> +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
> @@ -1715,13 +1715,6 @@ static struct iio_dev *st_lsm6dsx_alloc_iiodev(struct st_lsm6dsx_hw *hw,
> return iio_dev;
> }
>
> -static irqreturn_t st_lsm6dsx_handler_irq(int irq, void *private)
> -{
> - struct st_lsm6dsx_hw *hw = private;
> -
> - return hw->sip > 0 ? IRQ_WAKE_THREAD : IRQ_NONE;
> -}
> -
> static irqreturn_t st_lsm6dsx_handler_thread(int irq, void *private)
> {
> struct st_lsm6dsx_hw *hw = private;
> @@ -1779,7 +1772,7 @@ static int st_lsm6dsx_irq_setup(struct st_lsm6dsx_hw *hw)
> }
>
> err = devm_request_threaded_irq(hw->dev, hw->irq,
> - st_lsm6dsx_handler_irq,
> + NULL,
> st_lsm6dsx_handler_thread,
> irq_type | IRQF_ONESHOT,
> "lsm6dsx", hw);
next prev parent reply other threads:[~2019-10-05 11:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-16 13:56 [PATCH v10 1/5] iio: imu: st_lsm6dsx: move interrupt thread to core Sean Nyekjaer
2019-09-16 13:56 ` [PATCH v10 2/5] iio: imu: st_lsm6dsx: add motion events Sean Nyekjaer
2019-10-05 11:31 ` Jonathan Cameron
2019-09-16 13:56 ` [PATCH v10 3/5] iio: imu: st_lsm6dsx: add wakeup-source option Sean Nyekjaer
2019-10-05 11:35 ` Jonathan Cameron
2019-09-16 13:56 ` [PATCH v10 4/5] iio: imu: st_lsm6dsx: always enter interrupt thread Sean Nyekjaer
2019-10-05 11:37 ` Jonathan Cameron [this message]
2019-09-16 13:56 ` [PATCH v10 5/5] iio: imu: st_lsm6dsx: add motion report function and call from interrupt Sean Nyekjaer
2019-10-05 11:41 ` Jonathan Cameron
2019-09-16 16:52 ` [PATCH v10 1/5] iio: imu: st_lsm6dsx: move interrupt thread to core Lorenzo Bianconi
2019-10-05 11:27 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191005123732.5483c773@archlinux \
--to=jic23@kernel.org \
--cc=armando.visconti@st.com \
--cc=denis.ciocca@st.com \
--cc=linux-iio@vger.kernel.org \
--cc=lorenzo.bianconi83@gmail.com \
--cc=mario.tesi@st.com \
--cc=martin@geanix.com \
--cc=sean@geanix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).