From: Jonathan Cameron <jic23@kernel.org>
To: Alexandru Ardelean <alexandru.ardelean@analog.com>
Cc: <linux-iio@vger.kernel.org>
Subject: Re: [PATCH] iio: gyro: adis16080: replace mlock with own lock
Date: Sat, 5 Oct 2019 15:55:33 +0100 [thread overview]
Message-ID: <20191005155525.1e72f9bb@archlinux> (raw)
In-Reply-To: <20190919132303.9663-1-alexandru.ardelean@analog.com>
On Thu, 19 Sep 2019 16:23:03 +0300
Alexandru Ardelean <alexandru.ardelean@analog.com> wrote:
> The lock is used to protect the buffer during reads. Though the spi
> routines have their own locks, it may be the case that the buffer needs to
> be protected before it's stored and passed to the IIO read hooks.
>
> indio_dev's mlock was used before.
> This change replaces it with the driver's own lock.
>
> Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to poke holes in it.
Thanks,
Jonathan
> ---
> drivers/iio/gyro/adis16080.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/gyro/adis16080.c b/drivers/iio/gyro/adis16080.c
> index 236220d6de02..1b84b8e112fe 100644
> --- a/drivers/iio/gyro/adis16080.c
> +++ b/drivers/iio/gyro/adis16080.c
> @@ -38,10 +38,12 @@ struct adis16080_chip_info {
> * @us: actual spi_device to write data
> * @info: chip specific parameters
> * @buf: transmit or receive buffer
> + * @lock lock to protect buffer during reads
> **/
> struct adis16080_state {
> struct spi_device *us;
> const struct adis16080_chip_info *info;
> + struct mutex lock;
>
> __be16 buf ____cacheline_aligned;
> };
> @@ -82,9 +84,9 @@ static int adis16080_read_raw(struct iio_dev *indio_dev,
>
> switch (mask) {
> case IIO_CHAN_INFO_RAW:
> - mutex_lock(&indio_dev->mlock);
> + mutex_lock(&st->lock);
> ret = adis16080_read_sample(indio_dev, chan->address, val);
> - mutex_unlock(&indio_dev->mlock);
> + mutex_unlock(&st->lock);
> return ret ? ret : IIO_VAL_INT;
> case IIO_CHAN_INFO_SCALE:
> switch (chan->type) {
> @@ -196,6 +198,8 @@ static int adis16080_probe(struct spi_device *spi)
> /* this is only used for removal purposes */
> spi_set_drvdata(spi, indio_dev);
>
> + mutex_init(&st->lock);
> +
> /* Allocate the comms buffers */
> st->us = spi;
> st->info = &adis16080_chip_info[id->driver_data];
prev parent reply other threads:[~2019-10-05 14:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-19 13:23 [PATCH] iio: gyro: adis16080: replace mlock with own lock Alexandru Ardelean
2019-10-05 14:55 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191005155525.1e72f9bb@archlinux \
--to=jic23@kernel.org \
--cc=alexandru.ardelean@analog.com \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).