From: Jonathan Cameron <jic23@kernel.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: "Ardelean, Alexandru" <alexandru.Ardelean@analog.com>,
"lars@metafoo.de" <lars@metafoo.de>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>,
"Popa, Stefan Serban" <StefanSerban.Popa@analog.com>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Hennerich, Michael" <Michael.Hennerich@analog.com>,
"pmeerw@pmeerw.net" <pmeerw@pmeerw.net>,
"knaack.h@gmx.de" <knaack.h@gmx.de>
Subject: Re: [PATCH] iio: imu: adis16480: clean up a condition
Date: Sun, 6 Oct 2019 09:51:33 +0100 [thread overview]
Message-ID: <20191006095133.24fb89be@archlinux> (raw)
In-Reply-To: <20190926113630.GF27389@kadam>
On Thu, 26 Sep 2019 14:36:30 +0300
Dan Carpenter <dan.carpenter@oracle.com> wrote:
> On Thu, Sep 26, 2019 at 11:06:39AM +0000, Ardelean, Alexandru wrote:
> > On Thu, 2019-09-26 at 11:10 +0300, Dan Carpenter wrote:
> > > [External]
> > >
> > > The "t" variable is unsigned so it can't be less than zero. We really
> > > are just trying to prevent divide by zero bugs so just checking against
> > > zero is sufficient.
I'm not sure that true. It if were signed we'd be detecting that the
input from userspace was negative. That is clearly garbage for a frequency
control.. I'll hazard a guess that it was intended to catch that
as well as the divide by 0 case.
This would be clearer if we first checked that val and val2 are both not
negative, then did the zero test on t.
If people agree, anyone want to spin a patch to do that?
Thanks,
Jonathan
> > >
> > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> > > ---
> > > drivers/iio/imu/adis16480.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/iio/imu/adis16480.c b/drivers/iio/imu/adis16480.c
> > > index b99d73887c9f..e144e567675d 100644
> > > --- a/drivers/iio/imu/adis16480.c
> > > +++ b/drivers/iio/imu/adis16480.c
> > > @@ -318,7 +318,7 @@ static int adis16480_set_freq(struct iio_dev
> > > *indio_dev, int val, int val2)
> > > unsigned int t, reg;
> >
> > I would just change the type of "t" to "int".
> > Especially, since "val" & "val2" are "int".
> >
>
> Yeah, but negatives or high values are basically fine. We only care
> zero.
>
> regards,
> dan carpenter
>
next prev parent reply other threads:[~2019-10-06 8:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-26 8:10 [PATCH] iio: imu: adis16480: clean up a condition Dan Carpenter
2019-09-26 11:06 ` Ardelean, Alexandru
2019-09-26 11:36 ` Dan Carpenter
2019-10-06 8:51 ` Jonathan Cameron [this message]
2019-10-06 18:14 ` Dan Carpenter
2019-10-07 9:21 ` Jonathan Cameron
2019-10-07 14:18 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191006095133.24fb89be@archlinux \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=StefanSerban.Popa@analog.com \
--cc=alexandru.Ardelean@analog.com \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).