linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: linux-iio@vger.kernel.org
Subject: Re: [PULL] First set of IIO new device support etc for the 5.5 cycle.
Date: Sat, 12 Oct 2019 12:16:19 +0100	[thread overview]
Message-ID: <20191012121619.5c3e7453@archlinux> (raw)
In-Reply-To: <20191012105119.GA2074969@kroah.com>

On Sat, 12 Oct 2019 12:51:19 +0200
Greg KH <gregkh@linuxfoundation.org> wrote:

> On Sat, Oct 12, 2019 at 10:24:36AM +0100, Jonathan Cameron wrote:
> > The following changes since commit b73b93a2af3392b9b7b8ba7e818ee767499f9655:
> > 
> >   iio: adc: ad7192: Add sysfs ABI documentation (2019-09-08 10:34:49 +0100)
> > 
> > are available in the Git repository at:
> > 
> >   https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git tags/iio-for-5.5a  
> 
> I'm getting build warnings in drivers/iio/imu/adis16400.c, is that to be
> expected?
> 
> drivers/iio/imu/adis16400.c: In function ‘adis16334_get_freq’:
> drivers/iio/imu/adis16400.c:334:4: warning: ‘t’ may be used uninitialized in this function [-Wmaybe-uninitialized]
>   334 |  t >>= ADIS16334_RATE_DIV_SHIFT;
>       |    ^
> drivers/iio/imu/adis16400.c: In function ‘adis16400_get_freq’:
> drivers/iio/imu/adis16400.c:360:11: warning: ‘t’ may be used uninitialized in this function [-Wmaybe-uninitialized]
>   360 |  uint16_t t;
>       |           ^
>   CC [M]  drivers/iio/light/bh1750.o
> drivers/iio/imu/adis16400.c: In function ‘adis16400_read_raw’:
> drivers/iio/imu/adis16400.c:557:10: warning: ‘val16’ may be used uninitialized in this function [-Wmaybe-uninitialized]
>   557 |  int16_t val16;
>       |          ^~~~~
> drivers/iio/imu/adis16400.c: In function ‘adis16400_write_raw’:
> drivers/iio/imu/adis16400.c:424:14: warning: ‘val16’ may be used uninitialized in this function [-Wmaybe-uninitialized]
>   424 |       (val16 & ~0x07) | i);
>       |       ~~~~~~~^~~~~~~~
> drivers/iio/imu/adis16400.c:411:11: note: ‘val16’ was declared here
>   411 |  uint16_t val16;
>       |           ^~~~~
> 
> 
> Can you fix that up first?
> 
> thanks,
> 
> greg k-h
Hi Greg,

I got these as well, but as they weren't the result of anything done
in this series (seems to be GCC 8 getting fussier) I pointed them out
to Alex and he sent a fix.  Was about to queue it up for next series.
I'll tack it on here and send you a new pull in a few mins.

Thanks,

Jonathan

  reply	other threads:[~2019-10-12 11:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-12  9:24 [PULL] First set of IIO new device support etc for the 5.5 cycle Jonathan Cameron
2019-10-12 10:51 ` Greg KH
2019-10-12 11:16   ` Jonathan Cameron [this message]
2019-10-12 15:24     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191012121619.5c3e7453@archlinux \
    --to=jic23@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-iio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).