From: Jonathan Cameron <jic23@kernel.org>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>, <devicetree@vger.kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH v4 5/8] iio: adc: max1027: Introduce 12-bit devices support
Date: Sat, 12 Oct 2019 12:30:40 +0100 [thread overview]
Message-ID: <20191012123040.41e22379@archlinux> (raw)
In-Reply-To: <20191011144347.19146-6-miquel.raynal@bootlin.com>
On Fri, 11 Oct 2019 16:43:44 +0200
Miquel Raynal <miquel.raynal@bootlin.com> wrote:
> Maxim's max12xx series is very similar to the max10xx series, with the
> difference of the measurements depth which is upgraded from 10 to 12
> bits per channel. Everything else looks the same.
>
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Applied.
Thanks,
Jonathan
> ---
> drivers/iio/adc/Kconfig | 4 ++--
> drivers/iio/adc/max1027.c | 38 +++++++++++++++++++++++++++++++++++++-
> 2 files changed, 39 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
> index f0af3a42f53c..6ac16d738822 100644
> --- a/drivers/iio/adc/Kconfig
> +++ b/drivers/iio/adc/Kconfig
> @@ -508,8 +508,8 @@ config MAX1027
> select IIO_BUFFER
> select IIO_TRIGGERED_BUFFER
> help
> - Say yes here to build support for Maxim SPI ADC models
> - max1027, max1029 and max1031.
> + Say yes here to build support for Maxim SPI {10,12}-bit ADC models:
> + max1027, max1029, max1031, max1227, max1229 and max1231.
>
> To compile this driver as a module, choose M here: the module will be
> called max1027.
> diff --git a/drivers/iio/adc/max1027.c b/drivers/iio/adc/max1027.c
> index 8b449044bef5..e171db20c04a 100644
> --- a/drivers/iio/adc/max1027.c
> +++ b/drivers/iio/adc/max1027.c
> @@ -63,12 +63,18 @@ enum max1027_id {
> max1027,
> max1029,
> max1031,
> + max1227,
> + max1229,
> + max1231,
> };
>
> static const struct spi_device_id max1027_id[] = {
> {"max1027", max1027},
> {"max1029", max1029},
> {"max1031", max1031},
> + {"max1227", max1227},
> + {"max1229", max1229},
> + {"max1231", max1231},
> {}
> };
> MODULE_DEVICE_TABLE(spi, max1027_id);
> @@ -78,6 +84,9 @@ static const struct of_device_id max1027_adc_dt_ids[] = {
> { .compatible = "maxim,max1027" },
> { .compatible = "maxim,max1029" },
> { .compatible = "maxim,max1031" },
> + { .compatible = "maxim,max1227" },
> + { .compatible = "maxim,max1229" },
> + { .compatible = "maxim,max1231" },
> {},
> };
> MODULE_DEVICE_TABLE(of, max1027_adc_dt_ids);
> @@ -153,6 +162,18 @@ static const struct iio_chan_spec max1031_channels[] = {
> MAX1X31_CHANNELS(10),
> };
>
> +static const struct iio_chan_spec max1227_channels[] = {
> + MAX1X27_CHANNELS(12),
> +};
> +
> +static const struct iio_chan_spec max1229_channels[] = {
> + MAX1X29_CHANNELS(12),
> +};
> +
> +static const struct iio_chan_spec max1231_channels[] = {
> + MAX1X31_CHANNELS(12),
> +};
> +
> static const unsigned long max1027_available_scan_masks[] = {
> 0x000001ff,
> 0x00000000,
> @@ -190,6 +211,21 @@ static const struct max1027_chip_info max1027_chip_info_tbl[] = {
> .num_channels = ARRAY_SIZE(max1031_channels),
> .available_scan_masks = max1031_available_scan_masks,
> },
> + [max1227] = {
> + .channels = max1227_channels,
> + .num_channels = ARRAY_SIZE(max1227_channels),
> + .available_scan_masks = max1027_available_scan_masks,
> + },
> + [max1229] = {
> + .channels = max1229_channels,
> + .num_channels = ARRAY_SIZE(max1229_channels),
> + .available_scan_masks = max1029_available_scan_masks,
> + },
> + [max1231] = {
> + .channels = max1231_channels,
> + .num_channels = ARRAY_SIZE(max1231_channels),
> + .available_scan_masks = max1031_available_scan_masks,
> + },
> };
>
> struct max1027_state {
> @@ -486,5 +522,5 @@ static struct spi_driver max1027_driver = {
> module_spi_driver(max1027_driver);
>
> MODULE_AUTHOR("Philippe Reynes <tremyfr@yahoo.fr>");
> -MODULE_DESCRIPTION("MAX1027/MAX1029/MAX1031 ADC");
> +MODULE_DESCRIPTION("MAX1X27/MAX1X29/MAX1X31 ADC");
> MODULE_LICENSE("GPL v2");
next prev parent reply other threads:[~2019-10-12 11:34 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-11 14:43 [PATCH v4 0/8] Introduce max12xx ADC support Miquel Raynal
2019-10-11 14:43 ` [PATCH v4 1/8] iio: adc: max1027: Add debugfs register read support Miquel Raynal
2019-10-12 11:25 ` Jonathan Cameron
2019-10-11 14:43 ` [PATCH v4 2/8] iio: adc: max1027: Make it optional to use interrupts Miquel Raynal
2019-10-12 11:34 ` Jonathan Cameron
2019-10-11 14:43 ` [PATCH v4 3/8] iio: adc: max1027: Reset the device at probe time Miquel Raynal
2019-10-12 11:28 ` Jonathan Cameron
2019-10-11 14:43 ` [PATCH v4 4/8] iio: adc: max1027: Prepare the introduction of different resolutions Miquel Raynal
2019-10-12 11:29 ` Jonathan Cameron
2019-10-11 14:43 ` [PATCH v4 5/8] iio: adc: max1027: Introduce 12-bit devices support Miquel Raynal
2019-10-12 11:30 ` Jonathan Cameron [this message]
2019-10-11 14:43 ` [PATCH v4 6/8] dt-bindings: iio: adc: max1027: Mark interrupts as optional Miquel Raynal
2019-10-12 11:31 ` Jonathan Cameron
2019-10-11 14:43 ` [PATCH v4 7/8] dt-bindings: Add 1027/1029/1031 SPI ADCs as trivial devices Miquel Raynal
2019-10-14 15:38 ` Rob Herring
2019-10-11 14:43 ` [PATCH v4 8/8] dt-bindings: Add max12xx SPI ADC series " Miquel Raynal
2019-10-12 11:32 ` Jonathan Cameron
2019-10-14 15:38 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191012123040.41e22379@archlinux \
--to=jic23@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=miquel.raynal@bootlin.com \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).