linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	Lee Jones <lee.jones@linaro.org>,
	linux-iio@vger.kernel.org, Hartmut Knaack <knaack.h@gmx.de>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
	Mboumba Cedric Madianga <cedric.madianga@gmail.com>,
	devicetree@vger.kernel.org
Subject: Re: [PATCH 5/7 v4] mfd: ab8500: augment DT bindings
Date: Thu, 17 Oct 2019 22:22:38 +0100	[thread overview]
Message-ID: <20191017222238.673cd60b@archlinux> (raw)
In-Reply-To: <20191011134449.GA12969@bogus>

On Fri, 11 Oct 2019 08:44:49 -0500
Rob Herring <robh@kernel.org> wrote:

> On Fri, Oct 11, 2019 at 09:18:03AM +0200, Linus Walleij wrote:
> > As we migrate the AB8500 GPADC driver to use IIO, we need to augment
> > the bindings to account for defining the ADC channels in the device
> > tree.
> > 
> > Cc: devicetree@vger.kernel.org
> > Acked-by: Lee Jones <lee.jones@linaro.org>
> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> > ---
> > ChangeLog v3->v4:
> > - Fix the nodenames from "foo_node" to "foo-node"  
> 
> You forgot to update the example. With that fixed,
Given the number of these, I'm not that comfortable just
fixing this up.  Linus could you do me a follow up patch tiding
up this detail.

I don't want to delay the immutable branch any longer and
would hope the bindings are stable enough that no one will
need this little update in their tree as well as mfd 
(or IIO if Lee doesn't pick up the immutable)

Thanks,

Jonathan

> 
> Reviewed-by: Rob Herring <robh@kernel.org>
> 
> > - Remove 0 prefix from @0n to @n
> > ChangeLog v2->v3:
> > - Change "adc-channel@" to "channel@" as per preferred notation.
> > - Add some full stops to the end of sentences.
> > - Reference the new ADC-specific documentation for channel specifier
> >   etc.
> > - Collect Lee's ACK.
> > - Rebased on v5.4-rc1
> > ChangeLog v1->v2:
> > - Rebased on v5.3-rc5
> > ---
> >  .../devicetree/bindings/mfd/ab8500.txt        | 119 ++++++++++++++++++
> >  1 file changed, 119 insertions(+)  


  reply	other threads:[~2019-10-17 21:22 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-11  7:17 [PATCH 0/7 v4] AB8500 GPADC MFD to IIO conversion Linus Walleij
2019-10-11  7:17 ` [PATCH 1/7 v4] power: supply: ab8500_btemp: convert to IIO ADC Linus Walleij
2019-10-11  7:18 ` [PATCH 2/7 v4] power: supply: ab8500_charger: " Linus Walleij
2019-10-11  7:18 ` [PATCH 3/7 v4] power: supply: ab8500_fg: " Linus Walleij
2019-10-11  7:18 ` [PATCH 4/7 v4] hwmon: ab8500: " Linus Walleij
2019-10-11 13:13   ` Guenter Roeck
2019-10-11 20:48     ` Linus Walleij
2019-10-17 21:08       ` Jonathan Cameron
2019-10-11  7:18 ` [PATCH 5/7 v4] mfd: ab8500: augment DT bindings Linus Walleij
2019-10-11 13:44   ` Rob Herring
2019-10-17 21:22     ` Jonathan Cameron [this message]
2019-10-18  7:29       ` Lee Jones
2019-10-18  7:48         ` Linus Walleij
2019-10-18 13:24           ` Jonathan Cameron
2019-10-11  7:18 ` [PATCH 6/7 v4] iio: adc: New driver for the AB8500 GPADC Linus Walleij
2019-10-11  7:18 ` [PATCH 7/7 v4] mfd: Switch the AB8500 GPADC to IIO Linus Walleij
2019-10-17 21:27 ` [PATCH 0/7 v4] AB8500 GPADC MFD to IIO conversion Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191017222238.673cd60b@archlinux \
    --to=jic23@kernel.org \
    --cc=cedric.madianga@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=lee.jones@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=pmeerw@pmeerw.net \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).