From: Jonathan Cameron <jic23@kernel.org>
To: Tomasz Duszynski <tduszyns@gmail.com>
Cc: linux-iio@vger.kernel.org,
Jonathan Cameron <Jonathan.Cameron@huawei.com>
Subject: Re: [PATCH] iio: chemical: sps30: Explicity truncate constant by masking
Date: Fri, 18 Oct 2019 19:52:20 +0100 [thread overview]
Message-ID: <20191018195220.084d382c@archlinux> (raw)
In-Reply-To: <20191017164112.GA5100@arch>
On Thu, 17 Oct 2019 18:41:12 +0200
Tomasz Duszynski <tduszyns@gmail.com> wrote:
> On Sun, Oct 13, 2019 at 10:55:15AM +0100, jic23@kernel.org wrote:
> > From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> >
> > When breaking up a constant to write to two 8 bit registers
> > it isn't obvious to sparse that it was intentional.
> >
> > CHECK drivers/iio/chemical/sps30.c
> > drivers/iio/chemical/sps30.c:120:30: warning: cast truncates bits from constant value (8004 becomes 4)
> >
> > So in the interests of minimising noisy warnings, let us add
> > a mask.
> >
> > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > Cc: Tomasz Duszynski <tduszyns@gmail.com>
> > ---
> > drivers/iio/chemical/sps30.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/iio/chemical/sps30.c b/drivers/iio/chemical/sps30.c
> > index edbb956e81e8..acb9f8ecbb3d 100644
> > --- a/drivers/iio/chemical/sps30.c
> > +++ b/drivers/iio/chemical/sps30.c
> > @@ -117,7 +117,7 @@ static int sps30_do_cmd(struct sps30_state *state, u16 cmd, u8 *data, int size)
> > break;
> > case SPS30_READ_AUTO_CLEANING_PERIOD:
> > buf[0] = SPS30_AUTO_CLEANING_PERIOD >> 8;
> > - buf[1] = (u8)SPS30_AUTO_CLEANING_PERIOD;
> > + buf[1] = (u8)(SPS30_AUTO_CLEANING_PERIOD & 0xff);
> > /* fall through */
> > case SPS30_READ_DATA_READY_FLAG:
> > case SPS30_READ_DATA:
> > --
> > 2.23.0
> >
>
> Thanks for catching this.
> Acked-by: Tomasz Duszynski <tduszyns@gmail.com>
Applied. Thanks,
Jonathan
prev parent reply other threads:[~2019-10-18 18:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-13 9:55 [PATCH] iio: chemical: sps30: Explicity truncate constant by masking jic23
2019-10-17 16:41 ` Tomasz Duszynski
2019-10-18 18:52 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191018195220.084d382c@archlinux \
--to=jic23@kernel.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=linux-iio@vger.kernel.org \
--cc=tduszyns@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).