From: Jonathan Cameron <jic23@kernel.org>
To: Martin Kepplinger <martink@posteo.de>
Cc: Andrey Smirnov <andrew.smirnov@gmail.com>,
linux-iio@vger.kernel.org, Chris Healy <cphealy@gmail.com>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: mma8452: Re-word 'interrupt-names' description
Date: Tue, 22 Oct 2019 11:50:10 +0100 [thread overview]
Message-ID: <20191022115010.7957744e@archlinux> (raw)
In-Reply-To: <1a1bdf10-2505-6baf-8030-ce5e0e2b55a9@posteo.de>
On Tue, 22 Oct 2019 10:43:09 +0200
Martin Kepplinger <martink@posteo.de> wrote:
> On 22.10.19 05:56, Andrey Smirnov wrote:
> > Current wording in the binding documentation doesn't make it 100%
> > clear that only one of "INT1" and "INT2" will ever be used by the
> > driver and that specifying both has no advantages. Re-word it to make
> > this aspect a bit more explicit.
From a quick glance at the datasheet, it appears that the hardware
is capable of routing different interrupts to different pins, even
if the driver does not do so.
CTRL_REG5 has 6 different bits to set whether particular blocks have
their interrupt routed to INT1 or INT2, so it appears to be possible
to send some each way.
A binding is for the hardware not the driver, so if I'm right about this
the current text is correct and should be left alone.
Thanks,
Jonathan
> >
> > Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> > Cc: Chris Healy <cphealy@gmail.com>
> > Cc: Jonathan Cameron <jic23@kernel.org>
> > Cc: Hartmut Knaack <knaack.h@gmx.de>
> > Cc: Lars-Peter Clausen <lars@metafoo.de>
> > Cc: Peter Meerwald-Stadler <pmeerw@pmeerw.net>
> > Cc: linux-iio@vger.kernel.org
> > Cc: devicetree@vger.kernel.org
> > Cc: linux-kernel@vger.kernel.org
> > ---
> > Documentation/devicetree/bindings/iio/accel/mma8452.txt | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/iio/accel/mma8452.txt b/Documentation/devicetree/bindings/iio/accel/mma8452.txt
> > index e132394375a1..b27b6bee9eb6 100644
> > --- a/Documentation/devicetree/bindings/iio/accel/mma8452.txt
> > +++ b/Documentation/devicetree/bindings/iio/accel/mma8452.txt
> > @@ -17,7 +17,7 @@ Optional properties:
> >
> > - interrupts: interrupt mapping for GPIO IRQ
> >
> > - - interrupt-names: should contain "INT1" and/or "INT2", the accelerometer's
> > + - interrupt-names: should contain "INT1" or "INT2", the accelerometer's
> > interrupt line in use.
> >
> > - vdd-supply: phandle to the regulator that provides vdd power to the accelerometer.
> >
>
> Acked-by: Martin Kepplinger <martink@posteo.de>
>
> thanks,
>
> martin
>
next prev parent reply other threads:[~2019-10-22 10:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-22 3:56 [PATCH] dt-bindings: mma8452: Re-word 'interrupt-names' description Andrey Smirnov
2019-10-22 8:43 ` Martin Kepplinger
2019-10-22 10:50 ` Jonathan Cameron [this message]
2019-10-22 13:08 ` Martin Kepplinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191022115010.7957744e@archlinux \
--to=jic23@kernel.org \
--cc=andrew.smirnov@gmail.com \
--cc=cphealy@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martink@posteo.de \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).