From: Rob Herring <robh@kernel.org>
To: Beniamin Bia <beniamin.bia@analog.com>
Cc: jic23@kernel.org, lars@metafoo.de, Michael.Hennerich@analog.com,
knaack.h@gmx.de, pmeerw@pmeerw.net, gregkh@linuxfoundation.org,
linux-iio@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, mark.rutland@arm.com,
devicetree@vger.kernel.org, paulmck@linux.ibm.com,
mchehab+samsung@kernel.org, linus.walleij@linaro.org,
nicolas.ferre@microchip.com, biabeniamin@outlook.com
Subject: Re: [PATCH 3/4] dt-binding: iio: Add documentation for AD7091R5
Date: Tue, 29 Oct 2019 11:48:30 -0500 [thread overview]
Message-ID: <20191029164830.GA21417@bogus> (raw)
In-Reply-To: <20191021170608.26412-3-beniamin.bia@analog.com>
On Mon, Oct 21, 2019 at 08:06:07PM +0300, Beniamin Bia wrote:
> Documentation for AD7091R5 ADC was added.
>
> Signed-off-by: Beniamin Bia <beniamin.bia@analog.com>
> ---
> .../bindings/iio/adc/adi,ad7091r5.yaml | 53 +++++++++++++++++++
> 1 file changed, 53 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/adc/adi,ad7091r5.yaml
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7091r5.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7091r5.yaml
> new file mode 100644
> index 000000000000..d041cd76804e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7091r5.yaml
> @@ -0,0 +1,53 @@
> +# SPDX-License-Identifier: GPL-2.0
(GPL-2.0-only OR BSD-2-Clause) for new bindings please.
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/adc/adi,ad7091r5.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Analog Devices AD7091R5 4-Channel 12-Bit ADC
> +
> +maintainers:
> + - Beniamin Bia <beniamin.bia@analog.com>
> +
> +description: |
> + Analog Devices AD7091R5 4-Channel 12-Bit ADC
> + https://www.analog.com/media/en/technical-documentation/data-sheets/ad7091r-5.pdf
> +
> +properties:
> + compatible:
> + enum:
> + - adi,ad7091R5
lowercase 'r' or be consistent with the filename.
> +
> + reg:
> + maxItems: 1
> +
> + avcc-supply:
> + description:
> + Phandle to the Avcc power supply
> + maxItems: 1
Not an array, so you can drop this.
> +
> + interrupts:
> + maxItems: 1
> +
> +
> +required:
> + - compatible
> + - reg
Add:
additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> + #include <dt-bindings/interrupt-controller/irq.h>
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + adc@0 {
adc@2f
> + compatible = "adi,ad7091r5";
Doesn't match the schema.
> + reg = <0x2F>;
Lowercase hex.
> +
> + interrupts = <25 IRQ_TYPE_EDGE_FALLING>;
> + interrupt-parent = <&gpio>;
> + };
> + };
> +...
> --
> 2.17.1
>
next prev parent reply other threads:[~2019-10-29 16:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-21 17:06 [PATCH 1/4] iio: adc: Add support for AD7091R5 ADC Beniamin Bia
2019-10-21 14:45 ` Jonathan Cameron
2019-10-21 17:06 ` [PATCH 2/4] iio: adc: ad7091r5: Add scale and external VREF support Beniamin Bia
2019-10-21 14:54 ` Jonathan Cameron
2019-10-21 17:06 ` [PATCH 3/4] dt-binding: iio: Add documentation for AD7091R5 Beniamin Bia
2019-10-29 16:48 ` Rob Herring [this message]
2019-10-21 17:06 ` [PATCH 4/4] MAINTAINERS: add entry for AD7091R5 driver Beniamin Bia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191029164830.GA21417@bogus \
--to=robh@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=beniamin.bia@analog.com \
--cc=biabeniamin@outlook.com \
--cc=devel@driverdev.osuosl.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mchehab+samsung@kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=paulmck@linux.ibm.com \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).