Re: [PATCH v3 1/3] iio: adc: ltc2496: provide device tree binding document

From: Jonathan Cameron <jic23@kernel.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Hartmut Knaack <knaack.h@gmx.de>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Michael Hennerich <Michael.Hennerich@analog.com>,
	Stefan Popa <stefan.popa@analog.com>,
	Alexandru Ardelean <alexandru.Ardelean@analog.com>,
	linux-iio@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH v3 1/3] iio: adc: ltc2496: provide device tree binding document
Date: Sun, 1 Dec 2019 11:28:03 +0000	[thread overview]
Message-ID: <20191201112753.156881b8@archlinux> (raw)
In-Reply-To: <20191121210007.25646-2-u.kleine-koenig@pengutronix.de>

On Thu, 21 Nov 2019 22:00:05 +0100
Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote:

> The ADC only requires the standard stuff for spi devices and a reference
> voltage.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Rob, even with the issues below fixed I can't build test this and get
'no schema found in file'.

I can't seem to figure out why so if you could take a look, that would
be great.

Thanks,

Jonathan

> ---
>  .../bindings/iio/adc/lltc,ltc2496.yaml        | 37 +++++++++++++++++++
>  1 file changed, 37 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/adc/lltc,ltc2496.yaml
> 
> diff --git a/Documentation/devicetree/bindings/iio/adc/lltc,ltc2496.yaml b/Documentation/devicetree/bindings/iio/adc/lltc,ltc2496.yaml
> new file mode 100644
> index 000000000000..af485abeabd6
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/adc/lltc,ltc2496.yaml
> @@ -0,0 +1,37 @@
> +# SPDX-License-Identifier: GPL-2.0
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/adc/lltc,ltc2496.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Linear Technology / Analog Devices LTC2496 ADC
> +
> +properties:
> +  compatible:
> +    enum:
> +      - lltc,ltc2496
> +
> +  vref-supply:
> +    description: phandle to an external regulator providing the reference voltage
> +    allOf:
> +      - $ref: /schemas/types.yaml#/definitions/phandle
> +
> +  reg:
> +    description: spi chipselect number according to the usual spi bindings
> +
> +  spi-max-frequency:
> +    description: maximal spi bus frequency supported by the chip
> +
> +required:
> +  - compatible
> +  - vref-supply
> +  - reg
> +
> +examples:
> +  - |

Missed this before trying to build test.

Spaces used in DT not tabs, and this should be in an spi block.

Please check the example verifies using the instructions in
Documentation/devicetree/bindings/writing-bindings.rst

Thanks,

Jonathan

> +	adc@0 {
> +		compatible = "lltc,ltc2496";
> +		reg = <0>;
> +		vref-supply = <&ltc2496_reg>;
> +		spi-max-frequency = <2000000>;
> +	};