linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: "Ardelean, Alexandru" <alexandru.Ardelean@analog.com>
Cc: "linus.walleij@linaro.org" <linus.walleij@linaro.org>,
	"Hennerich, Michael" <Michael.Hennerich@analog.com>,
	"knaack.h@gmx.de" <knaack.h@gmx.de>,
	"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
	"pmeerw@pmeerw.net" <pmeerw@pmeerw.net>,
	"lars@metafoo.de" <lars@metafoo.de>
Subject: Re: [PATCH] iio: adf4350: Convert to use GPIO descriptor
Date: Sat, 7 Dec 2019 09:45:47 +0000	[thread overview]
Message-ID: <20191207094547.29f10f5d@archlinux> (raw)
In-Reply-To: <75b6824b87bc75b968f4dc1a616c68e686068d88.camel@analog.com>

On Mon, 2 Dec 2019 09:28:32 +0000
"Ardelean, Alexandru" <alexandru.Ardelean@analog.com> wrote:

> On Mon, 2019-12-02 at 10:16 +0100, Linus Walleij wrote:
> > On Mon, Dec 2, 2019 at 9:50 AM Ardelean, Alexandru
> > <alexandru.Ardelean@analog.com> wrote:
> >   
> > > > +     st->lock_detect_gpiod = devm_gpiod_get_optional(&spi->dev,
> > > > NULL,  
> > > 
> > > Would it make sense to name the GPIO here?
> > > Maybe name it "lock-detect"?
> > > 
> > > I do realize that this goes into the realm of changing some default
> > > behavior.
> > > And I am not sure how acceptable this is [generally].  
> > 
> > You can't name it in the devm_gpiod_get_optional() call as this
> > indicates the name the GPIO lines have in the device tree.
> > 
> > What you can do is add a call to
> > gpiod_set_consumer_name(gpiod, "name");
> > to explicitly name the line.
> > 
> > This will only affect the name assigned to the line
> > in debugfs and in the userspace tools like "lsgpio".
> >   
> 
> Ack.
> Thanks for the info.
> 
> Reviewed-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
Applied,

Thanks,

J
> 
> 
> > Yours,
> > Linus Walleij  


      reply	other threads:[~2019-12-07  9:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-02  8:38 [PATCH] iio: adf4350: Convert to use GPIO descriptor Linus Walleij
2019-12-02  8:50 ` Ardelean, Alexandru
2019-12-02  9:16   ` Linus Walleij
2019-12-02  9:28     ` Ardelean, Alexandru
2019-12-07  9:45       ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191207094547.29f10f5d@archlinux \
    --to=jic23@kernel.org \
    --cc=Michael.Hennerich@analog.com \
    --cc=alexandru.Ardelean@analog.com \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linus.walleij@linaro.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=pmeerw@pmeerw.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).