From: Jonathan Cameron <jic23@jic23.retrosnub.co.uk>
To: Beniamin Bia <beniamin.bia@analog.com>
Cc: <lars@metafoo.de>, <Michael.Hennerich@analog.com>,
<knaack.h@gmx.de>, <pmeerw@pmeerw.net>,
<linux-iio@vger.kernel.org>, <biabeniamin@outlook.com>,
<rwoerle@mibtec.de>
Subject: Re: [PATCH] iio: adc: ad7606: fix reading unnecessary data from device
Date: Sun, 8 Dec 2019 18:10:20 +0000 [thread overview]
Message-ID: <20191208181020.26c165de@archlinux> (raw)
In-Reply-To: <20191110104625.346152de@archlinux>
On Sun, 10 Nov 2019 10:46:25 +0000
Jonathan Cameron <jic23@kernel.org> wrote:
> On Mon, 4 Nov 2019 18:26:34 +0200
> Beniamin Bia <beniamin.bia@analog.com> wrote:
>
> > When a conversion result is being read from ADC, the driver reads the
> > number of channels + 1 because it thinks that IIO_CHAN_SOFT_TIMESTAMP
> > is also a physical channel. This patch fixes this issue.
> >
> > Fixes: 552a21f35477 ("staging: iio: adc: ad7606: Move out of staging")
> > Reported-by: Robert Wörle <rwoerle@mibtec.de>
> > Signed-off-by: Beniamin Bia <beniamin.bia@analog.com>
> Applied to the fixes-togreg branch of iio.git and marked for stable.
I was just about to send the pull including this and was checking the
fixes tags. The commit you have here doesn't seem to exist.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/iio/adc/ad7606.c?id=2985a5d88455a3edd51358fc77f61b684d0e9265
Seems to be the right one.
I've fixed it up.
Jonathan
>
> We are at that point in the cycle where I 'might' move this into
> the togreg branch for the merge window. All depends on what Linus
> says in his rc7 email that'll probably be out later today.
> Previously he hinted we'd have an rc8 this time. If that happens
> I'll do one last pull request and hence take the queued up fixes
> in with that for the merge window. I don't have anything critical
> enough to do a fixes pull this later in the cycle.
>
> Thanks,
>
> Jonathan
>
> > ---
> > drivers/iio/adc/ad7606.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/iio/adc/ad7606.c b/drivers/iio/adc/ad7606.c
> > index f5ba94c03a8d..e4683a68522a 100644
> > --- a/drivers/iio/adc/ad7606.c
> > +++ b/drivers/iio/adc/ad7606.c
> > @@ -85,7 +85,7 @@ static int ad7606_reg_access(struct iio_dev *indio_dev,
> >
> > static int ad7606_read_samples(struct ad7606_state *st)
> > {
> > - unsigned int num = st->chip_info->num_channels;
> > + unsigned int num = st->chip_info->num_channels - 1;
> > u16 *data = st->data;
> > int ret;
> >
>
prev parent reply other threads:[~2019-12-08 18:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-04 16:26 [PATCH] iio: adc: ad7606: fix reading unnecessary data from device Beniamin Bia
2019-11-10 10:46 ` Jonathan Cameron
2019-12-08 18:10 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191208181020.26c165de@archlinux \
--to=jic23@jic23.retrosnub.co.uk \
--cc=Michael.Hennerich@analog.com \
--cc=beniamin.bia@analog.com \
--cc=biabeniamin@outlook.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=rwoerle@mibtec.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).