linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-iio@vger.kernel.org, Hartmut Knaack <knaack.h@gmx.de>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
	Denis Ciocca <denis.ciocca@st.com>,
	Leonard Crestez <leonard.crestez@nxp.com>,
	Lorenzo Bianconi <lorenzo.bianconi83@gmail.com>
Subject: Re: [PATCH v1] iio: st_gyro: Correct data for LSM9DS0 gyro
Date: Mon, 13 Jan 2020 21:49:47 +0000	[thread overview]
Message-ID: <20200113214947.7126ad34@archlinux> (raw)
In-Reply-To: <20200113135739.GN32742@smile.fi.intel.com>

On Mon, 13 Jan 2020 15:57:39 +0200
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:

> On Mon, Dec 23, 2019 at 12:45:34PM +0000, Jonathan Cameron wrote:
> > On Tue, 17 Dec 2019 19:10:38 +0200
> > Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> >   
> > > The commit 41c128cb25ce ("iio: st_gyro: Add lsm9ds0-gyro support")
> > > assumes that gyro in LSM9DS0 is the same as others with 0xd4 WAI ID,
> > > but datasheet tells slight different story, i.e. the first scale factor
> > > for the chip is 245 dps, and not 250 dps.
> > > 
> > > Correct this by introducing a separate settings for LSM9DS0.
> > > 
> > > Fixes: 41c128cb25ce ("iio: st_gyro: Add lsm9ds0-gyro support")
> > > Depends-on: 45a4e4220bf4 ("iio: gyro: st_gyro: fix L3GD20H support")
> > > Cc: Leonard Crestez <leonard.crestez@nxp.com>
> > > Cc: Lorenzo Bianconi <lorenzo.bianconi83@gmail.com>
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>  
> > Looks good to me.  Will just leave it a bit longer to give others
> > time to check it.
> > 
> > Give me a shout if I seem to have missed this by about a week into the new
> > year (to let people get back from holidays etc).  
> 
> Gentle ping.
> 
Thanks.  Given timing and the fact the bug is old, I'll pull this into
the togreg branch and hopefully get it lined up for the coming merge window.

Thanks and sorry for the delay.

Jonathan


      reply	other threads:[~2020-01-13 21:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-17 17:10 [PATCH v1] iio: st_gyro: Correct data for LSM9DS0 gyro Andy Shevchenko
2019-12-23 12:45 ` Jonathan Cameron
2020-01-13 13:57   ` Andy Shevchenko
2020-01-13 21:49     ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200113214947.7126ad34@archlinux \
    --to=jic23@kernel.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=denis.ciocca@st.com \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=leonard.crestez@nxp.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=lorenzo.bianconi83@gmail.com \
    --cc=pmeerw@pmeerw.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).