From: Rob Herring <robh@kernel.org>
To: David Heidelberg <david@ixit.cz>
Cc: linux-iio@vger.kernel.org, "David Heidelberg" <david@ixit.cz>,
"Dmitry Osipenko" <digetx@gmail.com>,
"Michał Mirosław" <mirq-linux@rere.qmqm.pl>,
"Daniel Baluta" <daniel.baluta@nxp.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"Hartmut Knaack" <knaack.h@gmx.de>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Peter Meerwald-Stadler" <pmeerw@pmeerw.net>,
"Mark Rutland" <mark.rutland@arm.com>,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2 2/7] dt-bindings: iio: light: add support for Dyna-Image AL3010
Date: Fri, 31 Jan 2020 08:24:08 -0600 [thread overview]
Message-ID: <20200131142408.GA5196@bogus> (raw)
In-Reply-To: <20200128133052.201587-3-david@ixit.cz>
On Tue, 28 Jan 2020 14:30:47 +0100, David Heidelberg wrote:
> The Dyna-Image AL3010 is a 16-bit digital ambient light sensor which
> provides a multiple gain function with linear response over a dynamic
> range 1216/4863/19452/77806.
>
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
> .../devicetree/bindings/iio/light/al3010.yaml | 40 +++++++++++++++++++
> 1 file changed, 40 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/light/al3010.yaml
>
My bot found errors running 'make dt_binding_check' on your patch:
Documentation/devicetree/bindings/display/simple-framebuffer.example.dts:21.16-37.11: Warning (chosen_node_is_root): /example-0/chosen: chosen node must be at root node
Documentation/devicetree/bindings/iio/light/al3010.example.dts:20.17-30: Warning (reg_format): /example-0/i2c/al3010@1c:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1)
Documentation/devicetree/bindings/iio/light/al3010.example.dt.yaml: Warning (pci_device_bus_num): Failed prerequisite 'reg_format'
Documentation/devicetree/bindings/iio/light/al3010.example.dts:17.5-24.11: Warning (i2c_bus_bridge): /example-0/i2c: incorrect #address-cells for I2C bus
Documentation/devicetree/bindings/iio/light/al3010.example.dts:17.5-24.11: Warning (i2c_bus_bridge): /example-0/i2c: incorrect #size-cells for I2C bus
Documentation/devicetree/bindings/iio/light/al3010.example.dt.yaml: Warning (i2c_bus_reg): Failed prerequisite 'reg_format'
Documentation/devicetree/bindings/iio/light/al3010.example.dt.yaml: Warning (i2c_bus_reg): Failed prerequisite 'i2c_bus_bridge'
Documentation/devicetree/bindings/iio/light/al3010.example.dt.yaml: Warning (spi_bus_reg): Failed prerequisite 'reg_format'
Documentation/devicetree/bindings/iio/light/al3010.example.dts:18.23-23.15: Warning (avoid_default_addr_size): /example-0/i2c/al3010@1c: Relying on default #address-cells value
Documentation/devicetree/bindings/iio/light/al3010.example.dts:18.23-23.15: Warning (avoid_default_addr_size): /example-0/i2c/al3010@1c: Relying on default #size-cells value
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/iio/light/al3010.example.dt.yaml: al3010@1c: 'interrupt' is a required property
See https://patchwork.ozlabs.org/patch/1230351
Please check and re-submit.
next prev parent reply other threads:[~2020-01-31 14:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-28 13:30 [PATCH 0/7] iio: light: AL3010 introduction David Heidelberg
2020-01-28 13:30 ` [PATCH v2 1/7] dt-bindings: iio: light: add support for Dyna-Image AL3320A David Heidelberg
2020-01-31 14:23 ` Rob Herring
2020-01-28 13:30 ` [PATCH v2 2/7] dt-bindings: iio: light: add support for Dyna-Image AL3010 David Heidelberg
2020-01-28 19:43 ` Dmitry Osipenko
2020-01-31 14:24 ` Rob Herring [this message]
2020-01-31 14:28 ` Dmitry Osipenko
2020-01-28 13:30 ` [PATCH v2 3/7] iio: light: al3320a slightly improve code formatting David Heidelberg
2020-01-28 13:30 ` [PATCH v2 4/7] iio: light: add Dyna-Image AL3010 driver David Heidelberg
2020-01-28 13:30 ` [PATCH v2 5/7] iio: light: al3010 implement suspend support David Heidelberg
2020-01-28 19:46 ` Dmitry Osipenko
2020-01-28 13:30 ` [PATCH v2 6/7] iio: light: al3320a " David Heidelberg
2020-01-28 13:30 ` [PATCH v2 7/7] iio: light: al3320a allow module autoload and polish David Heidelberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200131142408.GA5196@bogus \
--to=robh@kernel.org \
--cc=daniel.baluta@nxp.com \
--cc=david@ixit.cz \
--cc=devicetree@vger.kernel.org \
--cc=digetx@gmail.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mirq-linux@rere.qmqm.pl \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).