From: David Heidelberg <david@ixit.cz>
To: linux-iio@vger.kernel.org
Cc: "David Heidelberg" <david@ixit.cz>,
"Dmitry Osipenko" <digetx@gmail.com>,
"Michał Mirosław" <mirq-linux@rere.qmqm.pl>,
"Daniel Baluta" <daniel.baluta@nxp.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"Hartmut Knaack" <knaack.h@gmx.de>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Peter Meerwald-Stadler" <pmeerw@pmeerw.net>
Subject: [PATCH v3 5/7] iio: light: al3010 implement suspend support
Date: Sat, 1 Feb 2020 19:00:22 +0100 [thread overview]
Message-ID: <20200201180024.328700-6-david@ixit.cz> (raw)
In-Reply-To: <20200201180024.328700-1-david@ixit.cz>
AL3010 is fairly simple chip, so for suspend is enough to disable and
later enable it again.
Reviewed-by: Dmitry Osipenko <digetx@gmail.com>
Tested-by: Dmitry Osipenko <digetx@gmail.com>
Signed-off-by: David Heidelberg <david@ixit.cz>
---
drivers/iio/light/al3010.c | 30 +++++++++++++++++++++++++-----
1 file changed, 25 insertions(+), 5 deletions(-)
diff --git a/drivers/iio/light/al3010.c b/drivers/iio/light/al3010.c
index 4b951c087c83..202f25b595c8 100644
--- a/drivers/iio/light/al3010.c
+++ b/drivers/iio/light/al3010.c
@@ -8,6 +8,9 @@
* IIO driver for AL3010 (7-bit I2C slave address 0x1C).
*
* TODO: interrupt support, thresholds
+ * When the driver will get support for interrupt handling, then interrupt
+ * will need to be disabled before turning sensor OFF in order to avoid
+ * potential races with the interrupt handling.
*/
#include <linux/i2c.h>
@@ -71,13 +74,18 @@ static const struct attribute_group al3010_attribute_group = {
.attrs = al3010_attributes,
};
+static int al3010_set_pwr(struct i2c_client *client, bool pwr)
+{
+ u8 val = pwr ? AL3010_CONFIG_ENABLE : AL3010_CONFIG_DISABLE;
+ return i2c_smbus_write_byte_data(client, AL3010_REG_SYSTEM, val);
+}
+
static int al3010_init(struct al3010_data *data)
{
int ret;
- /* power on */
- ret = i2c_smbus_write_byte_data(data->client, AL3010_REG_SYSTEM,
- AL3010_CONFIG_ENABLE);
+ ret = al3010_set_pwr(data->client, true);
+
if (ret < 0)
return ret;
@@ -185,10 +193,21 @@ static int al3010_probe(struct i2c_client *client,
static int al3010_remove(struct i2c_client *client)
{
- return i2c_smbus_write_byte_data(client, AL3010_REG_SYSTEM,
- AL3010_CONFIG_DISABLE);
+ return al3010_set_pwr(client, false);
}
+static int __maybe_unused al3010_suspend(struct device *dev)
+{
+ return al3010_set_pwr(to_i2c_client(dev), false);
+}
+
+static int __maybe_unused al3010_resume(struct device *dev)
+{
+ return al3010_set_pwr(to_i2c_client(dev), true);
+}
+
+SIMPLE_DEV_PM_OPS(al3010_pm_ops, al3010_suspend, al3010_resume);
+
static const struct i2c_device_id al3010_id[] = {
{"al3010", 0},
{}
@@ -205,6 +224,7 @@ static struct i2c_driver al3010_driver = {
.driver = {
.name = AL3010_DRV_NAME,
.of_match_table = al3010_of_match,
+ .pm = &al3010_pm_ops,
},
.probe = al3010_probe,
.remove = al3010_remove,
--
2.25.0
next prev parent reply other threads:[~2020-02-01 18:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-01 18:00 [PATCH v3 0/7] iio: light: AL3010 introduction David Heidelberg
2020-02-01 18:00 ` [PATCH v3 1/7] dt-bindings: iio: light: add support for Dyna-Image AL3320A David Heidelberg
2020-02-01 18:00 ` David Heidelberg
2020-02-01 18:59 ` Dmitry Osipenko
2020-02-01 18:00 ` David Heidelberg
2020-02-01 18:00 ` [PATCH v3 4/7] iio: light: add Dyna-Image AL3010 driver David Heidelberg
2020-02-02 10:22 ` Jonathan Cameron
2020-02-03 3:53 ` Michał Mirosław
2020-02-01 18:00 ` David Heidelberg [this message]
2020-02-01 18:00 ` [PATCH v3 6/7] iio: light: al3320a implement suspend support David Heidelberg
2020-02-02 10:24 ` Jonathan Cameron
2020-02-01 18:00 ` [PATCH v3 7/7] iio: light: al3320a allow module autoload and polish David Heidelberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200201180024.328700-6-david@ixit.cz \
--to=david@ixit.cz \
--cc=daniel.baluta@nxp.com \
--cc=digetx@gmail.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=mirq-linux@rere.qmqm.pl \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).