From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: Mike Looijmans <mike.looijmans@topic.nl>
Cc: Jonathan Cameron <jic23@kernel.org>, <linux-iio@vger.kernel.org>,
<knaack.h@gmx.de>, <lars@metafoo.de>, <pmeerw@pmeerw.net>
Subject: Re: [PATCH] iio: accel: Add support for the Bosch-Sensortec BMI088
Date: Mon, 16 Mar 2020 12:49:05 +0000 [thread overview]
Message-ID: <20200316124905.00003de8@Huawei.com> (raw)
In-Reply-To: <cba4a7c9-68a0-f268-bc78-ad6ab07fc70d@topic.nl>
On Mon, 16 Mar 2020 07:27:12 +0100
Mike Looijmans <mike.looijmans@topic.nl> wrote:
> On 15-03-2020 13:02, Jonathan Cameron wrote:
> > On Fri, 13 Mar 2020 15:04:15 +0100
> > Mike Looijmans <mike.looijmans@topic.nl> wrote:
> >
> >> The BMI088 is a combined module with both accelerometer and gyroscope.
> >> This adds the accelerometer driver support for the SPI interface.
> >> The gyroscope part is already supported by the BMG160 driver.
> >
> > There doesn't seem to be a specific compatible entry in the bmg160 driver.
> > Perhaps we should look to add one?
>
> I actually have it already, I'll submit it.
>
> >
> >>
> >> Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl>
> >
> > For a modern driver I'd normally expect to also see DT bindings.
> > How are you probing this?
>
> DT bindings, should I submit those as a separate patch?
> They're pretty trivial.
Yes. Separate patch for those as it means Rob doesn't have to plough through
the whole driver to find them!
>
> > There is a lot of half implemented code for features that I assume will follow
> > in later patches. Please rip all that out for now. A simple initial driver
> > is great but must only include the stuff it actually uses.
>
> I'll do some cleanup, didn't notice that.
>
> Mike.
next prev parent reply other threads:[~2020-03-16 12:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-13 14:04 [PATCH] iio: accel: Add support for the Bosch-Sensortec BMI088 Mike Looijmans
2020-03-15 12:02 ` Jonathan Cameron
2020-03-16 6:27 ` Mike Looijmans
2020-03-16 12:49 ` Jonathan Cameron [this message]
2020-03-17 13:55 ` Mike Looijmans
2020-03-16 7:32 ` [PATCH v2] " Mike Looijmans
2020-03-16 14:54 ` Lars-Peter Clausen
2020-03-17 13:58 ` Mike Looijmans
2020-03-19 15:48 ` [PATCH v3] " Mike Looijmans
2020-03-22 0:16 ` Andy Shevchenko
2020-03-23 9:21 ` Mike Looijmans
2020-03-23 10:45 ` Andy Shevchenko
2020-03-23 16:40 ` Jonathan Cameron
2020-03-22 17:47 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200316124905.00003de8@Huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=mike.looijmans@topic.nl \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).