From: Jonathan Cameron <jic23@kernel.org>
To: Alexandru Ardelean <alexandru.ardelean@analog.com>
Cc: <linux-iio@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<devicetree@vger.kernel.org>, <robh+dt@kernel.org>,
<Laszlo.Nagy@analog.com>, <Andrei.Grozav@analog.com>,
<Michael.Hennerich@analog.com>, <Istvan.Csomortani@analog.com>,
<Adrian.Costina@analog.com>, <Dragos.Bogdan@analog.com>
Subject: Re: [PATCH v11 3/8] iio: buffer-dmaengine: use %zu specifier for sprintf(align)
Date: Sat, 21 Mar 2020 17:22:17 +0000 [thread overview]
Message-ID: <20200321172217.18d9e01b@archlinux> (raw)
In-Reply-To: <20200321085315.11030-4-alexandru.ardelean@analog.com>
On Sat, 21 Mar 2020 10:53:10 +0200
Alexandru Ardelean <alexandru.ardelean@analog.com> wrote:
> The 'size_t' type behaves differently on 64-bit architectures, and causes
> compiler a warning of the sort "format '%u' expects argument of type
> 'unsigned int', but argument 3 has type 'size_t {aka long unsigned int}'".
>
> This change adds the correct specifier for the 'align' field.
>
> Fixes: 4538c18568099 ("iio: buffer-dmaengine: Report buffer length requirements")
> Reported-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
Applied thanks.
Given lack of users of this infrastructure, I'm not that fussed
about marking this for stable or similar. However, I don't
mind someone requesting a backport if it is useful to them.
Jonathan
> ---
> drivers/iio/buffer/industrialio-buffer-dmaengine.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/buffer/industrialio-buffer-dmaengine.c b/drivers/iio/buffer/industrialio-buffer-dmaengine.c
> index b129693af0fd..94da3b1ca3a2 100644
> --- a/drivers/iio/buffer/industrialio-buffer-dmaengine.c
> +++ b/drivers/iio/buffer/industrialio-buffer-dmaengine.c
> @@ -134,7 +134,7 @@ static ssize_t iio_dmaengine_buffer_get_length_align(struct device *dev,
> struct dmaengine_buffer *dmaengine_buffer =
> iio_buffer_to_dmaengine_buffer(indio_dev->buffer);
>
> - return sprintf(buf, "%u\n", dmaengine_buffer->align);
> + return sprintf(buf, "%zu\n", dmaengine_buffer->align);
> }
>
> static IIO_DEVICE_ATTR(length_align_bytes, 0444,
next prev parent reply other threads:[~2020-03-21 17:22 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-21 8:53 [PATCH v11 0/8] iio: adi-axi-adc,ad9647: Add support for AD9467 ADC Alexandru Ardelean
2020-03-21 8:53 ` [PATCH v11 1/8] include: fpga: adi-axi-common.h: fixup whitespace tab -> space Alexandru Ardelean
2020-03-21 8:53 ` [PATCH v11 2/8] include: fpga: adi-axi-common.h: add version helper macros Alexandru Ardelean
2020-03-21 17:21 ` Jonathan Cameron
2020-03-21 8:53 ` [PATCH v11 3/8] iio: buffer-dmaengine: use %zu specifier for sprintf(align) Alexandru Ardelean
2020-03-21 17:22 ` Jonathan Cameron [this message]
2020-03-21 8:53 ` [PATCH v11 4/8] iio: buffer-dmaengine: add dev-managed calls for buffer alloc Alexandru Ardelean
2020-03-21 17:22 ` Jonathan Cameron
2020-03-21 8:53 ` [PATCH v11 5/8] iio: adc: adi-axi-adc: add support for AXI ADC IP core Alexandru Ardelean
2020-03-21 17:15 ` Jonathan Cameron
2020-03-21 21:38 ` Andy Shevchenko
2020-03-22 9:35 ` Ardelean, Alexandru
2020-03-22 10:45 ` Andy Shevchenko
2020-03-22 16:11 ` Ardelean, Alexandru
2020-03-22 16:16 ` Kees Cook
2020-03-22 16:31 ` Ardelean, Alexandru
2020-03-22 16:44 ` Ardelean, Alexandru
2020-03-22 16:53 ` Jonathan Cameron
2020-03-22 17:40 ` Ardelean, Alexandru
2020-03-22 18:26 ` Jonathan Cameron
2020-03-24 7:10 ` Ardelean, Alexandru
2020-03-22 15:20 ` Jonathan Cameron
2020-03-21 8:53 ` [PATCH v11 6/8] dt-bindings: iio: adc: add bindings doc for AXI ADC driver Alexandru Ardelean
2020-03-21 17:23 ` Jonathan Cameron
2020-03-21 8:53 ` [PATCH v11 7/8] iio: adc: ad9467: add support AD9467 ADC Alexandru Ardelean
2020-03-21 17:23 ` Jonathan Cameron
2020-03-21 8:53 ` [PATCH v11 8/8] dt-bindings: iio: adc: add bindings doc for " Alexandru Ardelean
2020-03-21 17:24 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200321172217.18d9e01b@archlinux \
--to=jic23@kernel.org \
--cc=Adrian.Costina@analog.com \
--cc=Andrei.Grozav@analog.com \
--cc=Dragos.Bogdan@analog.com \
--cc=Istvan.Csomortani@analog.com \
--cc=Laszlo.Nagy@analog.com \
--cc=Michael.Hennerich@analog.com \
--cc=alexandru.ardelean@analog.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).