From: DEEPAK VARMA <mh12gx2825@gmail.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: outreachy-kernel@googlegroups.com,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Daniel Baluta <daniel.baluta@gmail.com>,
kieran.bingham@ideasonboard.com,
Lars-Peter Clausen <lars@metafoo.de>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Jonathan Cameron <jic23@kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Peter Meerwald <pmeerw@pmeerw.net>,
linux-iio <linux-iio@vger.kernel.org>
Subject: Re: [PATCH v2] media: staging/intel-ipu3: Reformat pointer initialization
Date: Mon, 23 Mar 2020 20:47:12 +0530 [thread overview]
Message-ID: <20200323151710.GA22110@deeUbuntu> (raw)
In-Reply-To: <CAHp75VcP1O_QwepgAHPBaTLcr_3=ynV6hsmcgvYnBCz7DdoWxw@mail.gmail.com>
On Mon, Mar 23, 2020 at 01:35:58AM +0200, Andy Shevchenko wrote:
> On Sun, Mar 22, 2020 at 8:54 PM Deepak R Varma <mh12gx2825@gmail.com> wrote:
> >
> > Reformat pointer initialization to make it more readable as per the
> > coding standards. Problem detected by checkpatch.
>
> > - struct imgu_v4l2_subdev *imgu_sd =
> > - container_of(ctrl->handler, struct imgu_v4l2_subdev, ctrl_handler);
> > + struct imgu_v4l2_subdev *imgu_sd = container_of(ctrl->handler,
> > + struct imgu_v4l2_subdev,
> > + ctrl_handler);
>
> I'm sorry I don't see benefit of this change, actually an opposite.
Hello Andy,
Thank you for your comment. To me, it helps quickly and clearly spot
*imgu_sd. Also the initialization looks more structured. But that's just
me.
I will wait to see if anyone else wants to share their thoughts, and
then circle back to you on next steps. Is that fine?
Deepak.
>
> --
> With Best Regards,
> Andy Shevchenko
next prev parent reply other threads:[~2020-03-23 15:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-22 18:53 [PATCH v2] media: staging/intel-ipu3: Reformat pointer initialization Deepak R Varma
2020-03-22 19:17 ` [Outreachy kernel] " Julia Lawall
2020-03-22 23:35 ` Andy Shevchenko
2020-03-23 15:17 ` DEEPAK VARMA [this message]
2020-03-28 13:24 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200323151710.GA22110@deeUbuntu \
--to=mh12gx2825@gmail.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy.shevchenko@gmail.com \
--cc=daniel.baluta@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=kieran.bingham@ideasonboard.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=outreachy-kernel@googlegroups.com \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).