From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Rohit Sarkar <rohitsarkar5398@gmail.com>,
linux-iio@vger.kernel.org, Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Jean-Baptiste Maneyrol <jmaneyrol@invensense.com>,
Linus Walleij <linus.walleij@linaro.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] iio: imu: inv_mpu6050: add debugfs register r/w interface
Date: Sat, 28 Mar 2020 17:45:34 +0000 [thread overview]
Message-ID: <20200328174534.6851a9c0@archlinux> (raw)
In-Reply-To: <20200327131901.GW1922688@smile.fi.intel.com>
On Fri, 27 Mar 2020 15:19:01 +0200
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> On Fri, Mar 27, 2020 at 06:40:23PM +0530, Rohit Sarkar wrote:
> > The debugfs interface provides direct access to read and write device
> > registers if debugfs is enabled.
> >
> > Signed-off-by: Rohit Sarkar <rohitsarkar5398@gmail.com>
> > ---
> > Changelog v1->v2
> > * grab a lock to protect driver state
> > * add a comma at the end of structure member initialisation
> >
> > drivers/iio/imu/inv_mpu6050/inv_mpu_core.c | 19 +++++++++++++++++++
> > 1 file changed, 19 insertions(+)
> >
> > diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
> > index 7cb9ff3d3e94..381a3fb09858 100644
> > --- a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
> > +++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
> > @@ -1248,12 +1248,31 @@ static const struct attribute_group inv_attribute_group = {
> > .attrs = inv_attributes
> > };
> >
> > +static int inv_mpu6050_reg_access(struct iio_dev *indio_dev,
> > + unsigned int reg,
> > + unsigned int writeval,
> > + unsigned int *readval)
> > +{
> > + struct inv_mpu6050_state *st = iio_priv(indio_dev);
>
> > + int ret = 0;
>
> Assignment is redundant, but I think maintainers may update this when applying.
Fixed up and applied to the togreg branch of iio.git and pushed
out as testing for the autobuilders to play with it.
Jonathan
>
> > +
> > + mutex_lock(&st->lock);
> > + if (readval)
> > + ret = regmap_read(st->map, reg, readval);
> > + else
> > + ret = regmap_write(st->map, reg, writeval);
> > + mutex_unlock(&st->lock);
> > +
> > + return ret;
> > +}
> > +
> > static const struct iio_info mpu_info = {
> > .read_raw = &inv_mpu6050_read_raw,
> > .write_raw = &inv_mpu6050_write_raw,
> > .write_raw_get_fmt = &inv_write_raw_get_fmt,
> > .attrs = &inv_attribute_group,
> > .validate_trigger = inv_mpu6050_validate_trigger,
> > + .debugfs_reg_access = &inv_mpu6050_reg_access,
> > };
> >
> > /**
> > --
> > 2.23.0.385.gbc12974a89
> >
>
next prev parent reply other threads:[~2020-03-28 17:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-27 13:10 [PATCH v2] iio: imu: inv_mpu6050: add debugfs register r/w interface Rohit Sarkar
2020-03-27 13:19 ` Andy Shevchenko
2020-03-28 17:45 ` Jonathan Cameron [this message]
2020-03-27 13:19 ` Andy Shevchenko
2020-03-27 14:08 ` Jean-Baptiste Maneyrol
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200328174534.6851a9c0@archlinux \
--to=jic23@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jmaneyrol@invensense.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=rohitsarkar5398@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).