From: Jonathan Cameron <jic23@kernel.org>
To: Aishwarya R <aishwaryarj100@gmail.com>
Cc: Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Ludovic Desroches <ludovic.desroches@microchip.com>,
Thomas Gleixner <tglx@linutronix.de>,
Allison Randal <allison@lohutok.net>,
Kefeng Wang <wangkefeng.wang@huawei.com>,
Stephen Boyd <swboyd@chromium.org>,
linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: adc: at91-adc: Use devm_platform_ioremap_resource
Date: Sun, 12 Apr 2020 11:13:34 +0100 [thread overview]
Message-ID: <20200412111334.46fccd20@archlinux> (raw)
In-Reply-To: <20200409151125.32677-1-aishwaryarj100@gmail.com>
On Thu, 9 Apr 2020 20:41:23 +0530
Aishwarya R <aishwaryarj100@gmail.com> wrote:
> Use the helper function that wraps the calls to
> platform_get_resource() and devm_ioremap_resource()
> together.
>
> Signed-off-by: Aishwarya R <aishwaryarj100@gmail.com>
Hi Aishwarya R,
Thanks for the patch. Good to add a little more detail to the description
and note that I do prefer one patch per driver for IIO drivers.
One other thing. Please use full name for the signed-off-by.
I see you use a longer form in your email later in the thread.
The DCO is a formal legal statement
https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin
so we tend to be fussy!
Thanks,
Jonathan
> ---
> drivers/iio/adc/at91_adc.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/iio/adc/at91_adc.c b/drivers/iio/adc/at91_adc.c
> index abe99856c823..0368b6dc6d60 100644
> --- a/drivers/iio/adc/at91_adc.c
> +++ b/drivers/iio/adc/at91_adc.c
> @@ -1152,7 +1152,6 @@ static int at91_adc_probe(struct platform_device *pdev)
> int ret;
> struct iio_dev *idev;
> struct at91_adc_state *st;
> - struct resource *res;
> u32 reg;
>
> idev = devm_iio_device_alloc(&pdev->dev, sizeof(struct at91_adc_state));
> @@ -1182,9 +1181,7 @@ static int at91_adc_probe(struct platform_device *pdev)
> if (st->irq < 0)
> return -ENODEV;
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -
> - st->reg_base = devm_ioremap_resource(&pdev->dev, res);
> + st->reg_base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(st->reg_base))
> return PTR_ERR(st->reg_base);
>
next prev parent reply other threads:[~2020-04-12 10:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-09 15:11 [PATCH] iio: adc: at91-adc: Use devm_platform_ioremap_resource Aishwarya R
2020-04-09 15:59 ` Alexandre Belloni
2020-04-10 10:55 ` Andy Shevchenko
2020-04-10 11:22 ` Alexandre Belloni
2020-04-10 16:37 ` Andy Shevchenko
2020-04-12 10:23 ` Jonathan Cameron
2020-04-10 9:43 ` Aishwarya R
2020-04-12 10:13 ` Jonathan Cameron [this message]
2020-04-12 13:56 ` Aishwarya R
2020-04-13 15:36 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200412111334.46fccd20@archlinux \
--to=jic23@kernel.org \
--cc=aishwaryarj100@gmail.com \
--cc=alexandre.belloni@bootlin.com \
--cc=allison@lohutok.net \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
--cc=nicolas.ferre@microchip.com \
--cc=pmeerw@pmeerw.net \
--cc=swboyd@chromium.org \
--cc=tglx@linutronix.de \
--cc=wangkefeng.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).