From: Tomasz Duszynski <tomasz.duszynski@octakon.com>
To: Andreas Klinger <ak@it-klinger.de>
Cc: <jic23@kernel.org>, <knaack.h@gmx.de>, <lars@metafoo.de>,
<pmeerw@pmeerw.net>, <bgolaszewski@baylibre.com>,
<linus.walleij@linaro.org>, <tglx@linutronix.de>,
<allison@lohutok.net>, <linux-iio@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] iio: bmp280: fix compensation of humidity
Date: Mon, 27 Apr 2020 17:12:14 +0200 [thread overview]
Message-ID: <20200427151214.GA6389@arch> (raw)
In-Reply-To: <20200427140017.GA25402@arbad>
On Mon, Apr 27, 2020 at 04:00:19PM +0200, Andreas Klinger wrote:
> Output of humidity compensation is limited to the range between 0 and 100
> percent. Add this to the compensation formula as described in the datasheet
> chapter 4.2.3.
>
> Signed-off-by: Andreas Klinger <ak@it-klinger.de>
> ---
> drivers/iio/pressure/bmp280-core.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/iio/pressure/bmp280-core.c b/drivers/iio/pressure/bmp280-core.c
> index 29c209cc1108..ac9ef1b63b07 100644
> --- a/drivers/iio/pressure/bmp280-core.c
> +++ b/drivers/iio/pressure/bmp280-core.c
> @@ -271,6 +271,9 @@ static u32 bmp280_compensate_humidity(struct bmp280_data *data,
> + (s32)2097152) * calib->H2 + 8192) >> 14);
> var -= ((((var >> 15) * (var >> 15)) >> 7) * (s32)calib->H1) >> 4;
>
> + var = var < 0 ? 0 : var;
> + var = var > 419430400 ? 419430400 : var;
> +
Looks that clamp_val() might come in handy here.
> return var >> 12;
> };
>
> --
> 2.20.1
prev parent reply other threads:[~2020-04-27 15:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-27 14:00 [PATCH] iio: bmp280: fix compensation of humidity Andreas Klinger
2020-04-27 15:12 ` Tomasz Duszynski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200427151214.GA6389@arch \
--to=tomasz.duszynski@octakon.com \
--cc=ak@it-klinger.de \
--cc=allison@lohutok.net \
--cc=bgolaszewski@baylibre.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).