From: Jonathan Cameron <jic23@kernel.org>
To: Mathieu Othacehe <m.othacehe@gmail.com>
Cc: knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 0/5] iio: vcnl: Add interrupts support for VCNL4010/20.
Date: Sun, 3 May 2020 14:55:40 +0100 [thread overview]
Message-ID: <20200503145540.419b37d2@archlinux> (raw)
In-Reply-To: <20200503092959.8806-1-m.othacehe@gmail.com>
On Sun, 3 May 2020 11:29:54 +0200
Mathieu Othacehe <m.othacehe@gmail.com> wrote:
> Hello,
>
> Here's a v7 fixing Jonathan remarks.
>
Great thanks. All applied to the togreg branch of iio.git and
pushed out as testing for the autobuilders to play with it.
Thanks,
Jonathan
> Thanks,
>
> Mathieu
>
> Changes from v6:
> * Add a missing Signed-off" tag in the first commit.
> * Clean exit pattern in vcnl4010_buffer_postenable.
>
> Changes from v5:
> * Fix i2c measure reads that are broken on the current driver for be16
> platforms.
> * Use read_avail callback for sampling frequency.
> * Move scan_index setting to the correct patch.
>
> Changes from v4:
> * Rename vcnl4010_in_periodic_mode into vcnl4010_is_in_periodic_mode
> and vcnl4010_thr_enabled into vcnl4010_is_thr_enabled.
> Also fix bitmask checking in those functions.
> * Refactor vcnl4010_write_proxy_samp_freq to loop in the
> other direction.
>
> Changes from v3:
> * Use i2c_smbus_read_byte_data and i2c_smbus_write_word_data
> for read and write functions.
> * Rename vcnl4010_prox_threshold to vcnl4010_config_threshold.
> * Do not lock i2c accesses as they are already protected.
> * Fix a typo in irq name.
> * Do not provide ALS sampling frequency operation, as ALS data
> are not buffered anymore.
> * Return bool in vcnl4010_in_periodic_mode and vcnl4010_thr_enabled
> functions.
>
> Changes from v2:
> * Rebase on iio testing branch.
> * Remove useless test in vcnl4010_probe_trigger.
>
> Changes from v1:
> * Split into four different patches.
> * Use iio_device_claim_direct_mode to protect
> raw access from buffer capture.
> * Requesting a sampling frequency above the limit is no longer possible.
> * Inline read_isr and write_isr functions.
> * Remove IIO_LIGHT data from buffer capture.
> * Make sure postenable and predisable functions respect the common form.
> * Do not set the trigger by default.
> * Remove the devm_iio_triggered_buffer_setup top half.
> Mathieu Othacehe (5):
> iio: vcnl4000: Fix i2c swapped word reading.
> iio: vcnl4000: Factorize data reading and writing.
> iio: vcnl4000: Add event support for VCNL4010/20.
> iio: vcnl4000: Add sampling frequency support for VCNL4010/20.
> iio: vcnl4000: Add buffer support for VCNL4010/20.
>
> drivers/iio/light/Kconfig | 2 +
> drivers/iio/light/vcnl4000.c | 753 ++++++++++++++++++++++++++++++++---
> 2 files changed, 689 insertions(+), 66 deletions(-)
>
prev parent reply other threads:[~2020-05-03 13:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-03 9:29 [PATCH v7 0/5] iio: vcnl: Add interrupts support for VCNL4010/20 Mathieu Othacehe
2020-05-03 9:29 ` [PATCH v7 1/5] iio: vcnl4000: Fix i2c swapped word reading Mathieu Othacehe
2020-05-03 9:29 ` [PATCH v7 2/5] iio: vcnl4000: Factorize data reading and writing Mathieu Othacehe
2020-05-03 9:29 ` [PATCH v7 3/5] iio: vcnl4000: Add event support for VCNL4010/20 Mathieu Othacehe
2020-05-03 9:29 ` [PATCH v7 4/5] iio: vcnl4000: Add sampling frequency " Mathieu Othacehe
2020-05-03 9:29 ` [PATCH v7 5/5] iio: vcnl4000: Add buffer " Mathieu Othacehe
2020-05-03 13:55 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200503145540.419b37d2@archlinux \
--to=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.othacehe@gmail.com \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).