From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: Jonathan Bakker <xc-racer2@live.ca>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Jonathan Cameron <jic23@kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald <pmeerw@pmeerw.net>,
Rob Herring <robh+dt@kernel.org>,
linux-iio <linux-iio@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Kate Stewart <kstewart@linuxfoundation.org>,
Greg KH <gregkh@linuxfoundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Linux Input <linux-input@vger.kernel.org>
Subject: Re: [PATCH 0/5] iio: accel: Add bma023 support to bma180
Date: Fri, 8 May 2020 13:47:33 +0100 [thread overview]
Message-ID: <20200508134733.0000233a@Huawei.com> (raw)
In-Reply-To: <BN6PR04MB0660BD7ABF64EC0C19A65A03A3A50@BN6PR04MB0660.namprd04.prod.outlook.com>
On Wed, 6 May 2020 20:49:17 -0700
Jonathan Bakker <xc-racer2@live.ca> wrote:
> Hi Linus,
>
> On 2020-05-06 5:47 a.m., Linus Walleij wrote:
> > On Sun, May 3, 2020 at 7:22 PM Jonathan Bakker <xc-racer2@live.ca> wrote:
> >
> >> This patchset adds support for the bma023 three axis accelerometer
> >> to the bma180 IIO driver. The bma023 is found on several ~2010
> >> phones, including the first-gen Galaxy S series.
> >>
> >> The bma023 differs from later chips (bma180, bma25x) in that it
> >> has no low power but still working mode and no temperature
> >> channel.
> >>
> >> The bma023 is already supported by a misc input driver (bma150), so
> >> when both are enabled, the iio driver is preferred. The bma150
> >> is very similar to the bma023, but has a temperature channel.
> >> Support for the bma150 is not added in this patchset.
> >
> > I'd say, if it's not too much trouble please also patch in
> > support for BMA150 and SMB380 to the IIO driver so
> > we can delete this old Input driver, we have done this
> > before and thes "input drivers" are just causing headaches
> > and wasting time for the Input maintainer.
> >
>
> Looking at the bma150, it looks the same. The temperature is implemented
> slightly differently than on the bma180+ (unsigned vs signed) but should
> be quite easy to add. I'll add a new patch for it in v2.
Great. Series looks fine to me as well, so should be fine to apply v2.
(subject to Dmitry Ack).
Jonathan
>
> > It can be in a separate patch set from this one if you
> > don't want to get stuck on this.
> >
> > Yours,
> > Linus Walleij
> >
>
> Thanks,
> Jonathan
prev parent reply other threads:[~2020-05-08 12:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-03 17:22 [PATCH 0/5] iio: accel: Add bma023 support to bma180 Jonathan Bakker
2020-05-06 12:47 ` Linus Walleij
2020-05-07 3:49 ` Jonathan Bakker
2020-05-08 12:47 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200508134733.0000233a@Huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=kstewart@linuxfoundation.org \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
--cc=xc-racer2@live.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).