From: Jacopo Mondi <jacopo@jmondi.org>
To: Jonathan Cameron <jic23@kernel.org>
Cc: linux-iio@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, Akinobu Mita <akinobu.mita@gmail.com>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>
Subject: Re: [PATCH 3/3] dt-bindings: iio: adc: maxim,max9611 yaml conversions
Date: Thu, 23 Jul 2020 11:30:51 +0200 [thread overview]
Message-ID: <20200723093051.kq7nc72s6532zoct@uno.localdomain> (raw)
In-Reply-To: <20200722171224.989138-4-jic23@kernel.org>
On Wed, Jul 22, 2020 at 06:12:24PM +0100, Jonathan Cameron wrote:
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> Straight forward conversion of this binding for this
> current sense amplifier and ADC.
>
> Cc: Jacopo Mondi <jacopo@jmondi.org>
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> ---
> .../devicetree/bindings/iio/adc/max9611.txt | 27 ----------
> .../bindings/iio/adc/maxim,max9611.yaml | 49 +++++++++++++++++++
> 2 files changed, 49 insertions(+), 27 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/max9611.txt b/Documentation/devicetree/bindings/iio/adc/max9611.txt
> deleted file mode 100644
> index ab4f43145ae5..000000000000
> --- a/Documentation/devicetree/bindings/iio/adc/max9611.txt
> +++ /dev/null
> @@ -1,27 +0,0 @@
> -* Maxim max9611/max9612 current sense amplifier with 12-bits ADC interface
> -
> -Maxim max9611/max9612 is an high-side current sense amplifier with integrated
> -12-bits ADC communicating over I2c bus.
> -The device node for this driver shall be a child of a I2c controller.
> -
> -Required properties
> - - compatible: Should be "maxim,max9611" or "maxim,max9612"
> - - reg: The 7-bits long I2c address of the device
> - - shunt-resistor-micro-ohms: Value, in micro Ohms, of the current sense shunt
> - resistor
> -
> -Example:
> -
> -&i2c4 {
> - csa: adc@7c {
> - compatible = "maxim,max9611";
> - reg = <0x7c>;
> -
> - shunt-resistor-micro-ohms = <5000>;
> - };
> -};
> -
> -This device node describes a current sense amplifier sitting on I2c4 bus
> -with address 0x7c (read address is 0xf9, write address is 0xf8).
> -A sense resistor of 0,005 Ohm is installed between RS+ and RS- current-sensing
> -inputs.
> diff --git a/Documentation/devicetree/bindings/iio/adc/maxim,max9611.yaml b/Documentation/devicetree/bindings/iio/adc/maxim,max9611.yaml
> new file mode 100644
> index 000000000000..a9fc05e6b62c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/adc/maxim,max9611.yaml
> @@ -0,0 +1,49 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/adc/maxim,max9611.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Maxim MAX9611 and similar current sense amplifiers with integrated ADCs
> +
> +maintainers:
> + - Jacopo Mondi <jacopo@jmondi.org>
> +
> +description: |
> + These devices combine a high-side current sense amplifier with a 12 bit ADC.
> + They have an i2c interface.
> +
> +properties:
> + compatible:
> + enum:
> + - maxim,max9611
> + - maxim,max9612
> +
> + reg:
> + maxItems: 1
> +
> + shunt-resistor-micro-ohms:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description: |
> + Value in micro Ohms of the shunt resistor connected between the RS+ and
> + RS- inputs, across which the current is measured. Value needed to compute
^ Double space
> + the scaling of the measured current.
> +
With additionalProperties added
Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>
Thanks
j
> +required:
> + - compatible
> + - reg
> + - shunt-resistor-micro-ohms
> +
> +examples:
> + - |
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + adc@7c {
> + compatible = "maxim,max9611";
> + reg = <0x7c>;
> + shunt-resistor-micro-ohms = <5000>;
> + };
> + };
> +...
> --
> 2.27.0
>
next prev parent reply other threads:[~2020-07-23 9:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-22 17:12 [PATCH 0/3] dt-bindings: iio: adc: Maxim ADC yaml conversions Jonathan Cameron
2020-07-22 17:12 ` [PATCH 1/3] dt-bindings: iio: adc: maxim,max11100 yaml conversion Jonathan Cameron
2020-07-23 9:31 ` Jacopo Mondi
2020-07-23 21:21 ` Rob Herring
2020-08-01 16:38 ` Jonathan Cameron
2020-07-22 17:12 ` [PATCH 2/3] dt-bindings: iio: adc: maxim,max1118 " Jonathan Cameron
2020-07-23 21:21 ` Rob Herring
2020-07-22 17:12 ` [PATCH 3/3] dt-bindings: iio: adc: maxim,max9611 yaml conversions Jonathan Cameron
2020-07-23 9:30 ` Jacopo Mondi [this message]
2020-07-23 21:22 ` Rob Herring
2020-08-01 16:42 ` Jonathan Cameron
2020-07-22 17:18 ` [PATCH 0/3] dt-bindings: iio: adc: Maxim ADC " Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200723093051.kq7nc72s6532zoct@uno.localdomain \
--to=jacopo@jmondi.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=akinobu.mita@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).