From: Jonathan Cameron <jic23@kernel.org>
To: Christian Eggers <ceggers@arri.de>
Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
"Peter Meerwald-Stadler" <pmeerw@pmeerw.net>,
<linux-iio@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] iio: documentation: light: Add as73211 sysfs documentation
Date: Sun, 9 Aug 2020 12:30:00 +0100 [thread overview]
Message-ID: <20200809123000.5131effd@archlinux> (raw)
In-Reply-To: <20200809074335.23734-1-ceggers@arri.de>
On Sun, 9 Aug 2020 09:43:35 +0200
Christian Eggers <ceggers@arri.de> wrote:
> The driver for the as73211 light sensor provides the following not yet
> documented sysfs entries:
> - in_intensity_(x|y|z)_raw
> - in_intensity_(x|y|z)_scale
> - in_intensity_sampling_frequency(_available)
> - in_intensity_hardwaregain(_available)
> - in_intensity_integration_time
>
> Signed-off-by: Christian Eggers <ceggers@arri.de>
Hi Christian,
Just one tiny nitpick. Otherwise looks good to me!
Thanks for doing this,
Jonathan
> ---
>
> On Thursday, 6 August 2020, 19:44:51 CEST, Jonathan Cameron wrote:
> Hi Jonathan,
>
> > Hi Christian,
> >
> > I'll take this, but please send a follow up patch to add documentation
> > for in_intensity_x_raw and all the other new ABI this adds in
> > Documentation/ABI/testing/sysfs-bus-iio
> > I should have mentioned that earlier, but kind of assumed we already
> > had these documented for some reason!
> > [...]
> > Insert them into the relevant groups that already exist. In some cases
> > it will just be adding an entry with no specific explanation.
> > For the _raw attribute add a bit more info about what x, y and z are
> > (basically just say they are from cie1931 (I think?)
>
> I added all sysfs entries which were not present in 5.8-rc6.
>
> Best regards
> Christian
>
> Documentation/ABI/testing/sysfs-bus-iio | 26 ++++++++++++++++++++++++-
> 1 file changed, 25 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/ABI/testing/sysfs-bus-iio b/Documentation/ABI/testing/sysfs-bus-iio
> index d3e53a6d8331..14ae4bf053c5 100644
> --- a/Documentation/ABI/testing/sysfs-bus-iio
> +++ b/Documentation/ABI/testing/sysfs-bus-iio
> @@ -40,6 +40,7 @@ Description:
> buffered samples and events for device X.
>
> What: /sys/bus/iio/devices/iio:deviceX/sampling_frequency
> +What: /sys/bus/iio/devices/iio:deviceX/in_intensity_sampling_frequency
> What: /sys/bus/iio/devices/iio:deviceX/buffer/sampling_frequency
> What: /sys/bus/iio/devices/triggerX/sampling_frequency
> KernelVersion: 2.6.35
> @@ -55,6 +56,7 @@ Description:
> then it is to be found in the base device directory.
>
> What: /sys/bus/iio/devices/iio:deviceX/sampling_frequency_available
> +What: /sys/bus/iio/devices/iio:deviceX/in_intensity_sampling_frequency_available
> What: /sys/bus/iio/devices/iio:deviceX/in_proximity_sampling_frequency_available
> What: /sys/.../iio:deviceX/buffer/sampling_frequency_available
> What: /sys/bus/iio/devices/triggerX/sampling_frequency_available
> @@ -374,6 +376,9 @@ What: /sys/bus/iio/devices/iio:deviceX/in_velocity_sqrt(x^2+y^2+z^2)_scale
> What: /sys/bus/iio/devices/iio:deviceX/in_illuminance_scale
> What: /sys/bus/iio/devices/iio:deviceX/in_countY_scale
> What: /sys/bus/iio/devices/iio:deviceX/in_angl_scale
> +What: /sys/bus/iio/devices/iio:deviceX/in_intensity_x_scale
> +What: /sys/bus/iio/devices/iio:deviceX/in_intensity_y_scale
> +What: /sys/bus/iio/devices/iio:deviceX/in_intensity_z_scale
> KernelVersion: 2.6.35
> Contact: linux-iio@vger.kernel.org
> Description:
> @@ -484,6 +489,7 @@ Description:
> are listed in this attribute.
>
> What /sys/bus/iio/devices/iio:deviceX/out_voltageY_hardwaregain
> +What: /sys/bus/iio/devices/iio:deviceX/in_intensity_hardwaregain
> What: /sys/bus/iio/devices/iio:deviceX/in_intensity_red_hardwaregain
> What: /sys/bus/iio/devices/iio:deviceX/in_intensity_green_hardwaregain
> What: /sys/bus/iio/devices/iio:deviceX/in_intensity_blue_hardwaregain
> @@ -494,6 +500,13 @@ Description:
> Hardware applied gain factor. If shared across all channels,
> <type>_hardwaregain is used.
>
> +What: /sys/bus/iio/devices/iio:deviceX/in_intensity_hardwaregain_available
> +KernelVersion: 5.10
> +Contact: linux-iio@vger.kernel.org
> +Description:
> + Lists all available hardware applied gain factors. Shared across all
> + channels.
> +
> What: /sys/.../in_accel_filter_low_pass_3db_frequency
> What: /sys/.../in_magn_filter_low_pass_3db_frequency
> What: /sys/.../in_anglvel_filter_low_pass_3db_frequency
> @@ -1333,6 +1346,7 @@ Description:
> standardised CIE Erythemal Action Spectrum. UV index values range
> from 0 (low) to >=11 (extreme).
>
> +What: /sys/.../iio:deviceX/in_intensity_integration_time
> What: /sys/.../iio:deviceX/in_intensity_red_integration_time
> What: /sys/.../iio:deviceX/in_intensity_green_integration_time
> What: /sys/.../iio:deviceX/in_intensity_blue_integration_time
> @@ -1342,7 +1356,8 @@ KernelVersion: 3.12
> Contact: linux-iio@vger.kernel.org
> Description:
> This attribute is used to get/set the integration time in
> - seconds.
> + seconds. If shared across all channels, <type>_integration_time
> + is used.
If it is shared across 'ALL' channels then it will be just integration_time
If it is shared across all channels of a given type, it will be <type>_integration_time.
>
> What: /sys/.../iio:deviceX/in_velocity_sqrt(x^2+y^2+z^2)_integration_time
> KernelVersion: 4.0
> @@ -1739,3 +1754,12 @@ KernelVersion: 5.5
> Contact: linux-iio@vger.kernel.org
> Description:
> One of the following thermocouple types: B, E, J, K, N, R, S, T.
> +
> +What: /sys/bus/iio/devices/iio:deviceX/in_intensity_x_raw
> +What: /sys/bus/iio/devices/iio:deviceX/in_intensity_y_raw
> +What: /sys/bus/iio/devices/iio:deviceX/in_intensity_z_raw
> +KernelVersion: 5.10
> +Contact: linux-iio@vger.kernel.org
> +Description:
> + Unscaled light intensity according to CIE 1931/DIN 5033 color space.
> + Units after application of scale are nano nanowatts per square meter.
next prev parent reply other threads:[~2020-08-09 11:30 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-05 5:57 [PATCH v6 0/2] iio: light: Support AMS AS73211 digital XYZ sensor Christian Eggers
2020-08-05 5:57 ` [PATCH v6 1/2] dt-bindings: iio: light: add AMS AS73211 support Christian Eggers
2020-08-06 17:44 ` Jonathan Cameron
2020-08-05 5:57 ` [PATCH v6 2/2] iio: light: as73211: New driver Christian Eggers
2020-08-05 7:39 ` Andy Shevchenko
2020-08-06 17:44 ` Jonathan Cameron
2020-08-07 15:46 ` Christian Eggers
2020-08-08 16:14 ` Jonathan Cameron
2020-08-09 7:43 ` [PATCH] iio: documentation: light: Add as73211 sysfs documentation Christian Eggers
2020-08-09 11:30 ` Jonathan Cameron [this message]
2020-08-10 5:24 ` [PATCH v2] " Christian Eggers
2020-08-16 9:19 ` Jonathan Cameron
2020-08-10 9:00 ` [PATCH] " Pavel Machek
2020-08-10 9:57 ` Christian Eggers
2020-08-10 12:35 ` Pavel Machek
2020-08-10 13:24 ` Christian Eggers
2020-08-16 9:18 ` Jonathan Cameron
2020-09-01 18:46 ` [PATCH v6 2/2] iio: light: as73211: New driver Jonathan Cameron
2020-09-03 18:43 ` Jonathan Cameron
2020-09-09 18:05 ` Christian Eggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200809123000.5131effd@archlinux \
--to=jic23@kernel.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=andy.shevchenko@gmail.com \
--cc=ceggers@arri.de \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).