From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Jonathan Cameron <jic23@kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Michal Simek <michal.simek@xilinx.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Guenter Roeck <linux@roeck-us.net>,
linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Bartosz Golaszewski <bgolaszewski@baylibre.com>
Subject: Re: [PATCH v7 1/3] devres: provide devm_krealloc()
Date: Mon, 17 Aug 2020 20:39:08 +0300 [thread overview]
Message-ID: <20200817173908.GS1891694@smile.fi.intel.com> (raw)
In-Reply-To: <20200817170535.17041-2-brgl@bgdev.pl>
On Mon, Aug 17, 2020 at 07:05:33PM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>
> Implement the managed variant of krealloc(). This function works with
> all memory allocated by devm_kmalloc() (or devres functions using it
> implicitly like devm_kmemdup(), devm_kstrdup() etc.).
>
> Managed realloc'ed chunks can be manually released with devm_kfree().
Thanks for an update! My comments / questions below.
...
> +static struct devres *to_devres(void *data)
> +{
> + return (struct devres *)((u8 *)data - ALIGN(sizeof(struct devres),
> + ARCH_KMALLOC_MINALIGN));
Do you really need both explicit castings?
> +}
...
> + total_old_size = ksize(to_devres(ptr));
But how you can guarantee this pointer:
- belongs to devres,
- hasn't gone while you run a ksize()?
...
> + new_dr = alloc_dr(devm_kmalloc_release,
> + total_new_size, gfp, dev_to_node(dev));
Can you move some parameters to the previous line?
> + if (!new_dr)
> + return NULL;
...
> + spin_lock_irqsave(&dev->devres_lock, flags);
> +
> + old_dr = find_dr(dev, devm_kmalloc_release, devm_kmalloc_match, ptr);
> + if (!old_dr) {
> + spin_unlock_irqrestore(&dev->devres_lock, flags);
> + devres_free(new_dr);
> + WARN(1, "Memory chunk not managed or managed by a different device.");
> + return NULL;
> + }
> +
> + replace_dr(dev, &old_dr->node, &new_dr->node);
> +
> + spin_unlock_irqrestore(&dev->devres_lock, flags);
> +
> + memcpy(new_dr->data, old_dr->data, devres_data_size(total_old_size));
But new_dr may concurrently gone at this point, no? It means memcpy() should be
under spin lock.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-08-17 17:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-17 17:05 [PATCH v7 0/3] devres: provide and use devm_krealloc() Bartosz Golaszewski
2020-08-17 17:05 ` [PATCH v7 1/3] devres: provide devm_krealloc() Bartosz Golaszewski
2020-08-17 17:39 ` Andy Shevchenko [this message]
2020-08-17 20:02 ` Bartosz Golaszewski
2020-08-18 8:25 ` Andy Shevchenko
2020-08-18 16:27 ` Bartosz Golaszewski
2020-08-18 17:10 ` Andy Shevchenko
2020-08-18 18:13 ` Bartosz Golaszewski
2020-08-19 9:14 ` Andy Shevchenko
2020-08-17 17:05 ` [PATCH v7 2/3] hwmon: pmbus: use more devres helpers Bartosz Golaszewski
2020-08-17 17:05 ` [PATCH v7 3/3] iio: adc: xilinx-xadc: use devm_krealloc() Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200817173908.GS1891694@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bgolaszewski@baylibre.com \
--cc=brgl@bgdev.pl \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=michal.simek@xilinx.com \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).