From: Jonathan Cameron <jic23@kernel.org>
To: Alexandru Ardelean <ardeleanalex@gmail.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
Hartmut Knaack <knaack.h@gmx.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Alexandru Ardelean <alexandru.ardelean@analog.com>,
linux-iio <linux-iio@vger.kernel.org>
Subject: Re: [PATCH] iio: buffer-dmaengine: adjust `bytes_used` with residue info
Date: Sat, 29 Aug 2020 16:51:34 +0100 [thread overview]
Message-ID: <20200829165134.3361315a@archlinux> (raw)
In-Reply-To: <CA+U=Dsp8KXNzmVGf9N=A+h7DyC2L7Hk2A7N4ERPL4jc+-M_mFg@mail.gmail.com>
On Wed, 26 Aug 2020 09:36:39 +0300
Alexandru Ardelean <ardeleanalex@gmail.com> wrote:
> On Wed, Aug 26, 2020 at 8:22 AM Lars-Peter Clausen <lars@metafoo.de> wrote:
> >
> > From: Alexandru Ardelean <alexandru.ardelean@analog.com>
> >
> > A transfer may fall shorter than the bytes in the block.
> > This information is available in the residue from the DMA engine, so we can
> > compute actual `bytes_used` with that by subtracting the residue.
> >
>
> This was in my pipeline as well [obviously].
> Thanks :)
>
> > Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
> > Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
"smells" like a fix. Is it? Or are we looking at something that
only matters for some future hardware, or an optmization?
If it's a fix, where is the fixes tag?
Thanks,
Jonathan
> > ---
> > drivers/iio/buffer/industrialio-buffer-dmaengine.c | 6 ++++--
> > 1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/iio/buffer/industrialio-buffer-dmaengine.c b/drivers/iio/buffer/industrialio-buffer-dmaengine.c
> > index 6dedf12b69a4..5789bda0745b 100644
> > --- a/drivers/iio/buffer/industrialio-buffer-dmaengine.c
> > +++ b/drivers/iio/buffer/industrialio-buffer-dmaengine.c
> > @@ -45,7 +45,8 @@ static struct dmaengine_buffer *iio_buffer_to_dmaengine_buffer(
> > return container_of(buffer, struct dmaengine_buffer, queue.buffer);
> > }
> >
> > -static void iio_dmaengine_buffer_block_done(void *data)
> > +static void iio_dmaengine_buffer_block_done(void *data,
> > + const struct dmaengine_result *result)
> > {
> > struct iio_dma_buffer_block *block = data;
> > unsigned long flags;
> > @@ -53,6 +54,7 @@ static void iio_dmaengine_buffer_block_done(void *data)
> > spin_lock_irqsave(&block->queue->list_lock, flags);
> > list_del(&block->head);
> > spin_unlock_irqrestore(&block->queue->list_lock, flags);
> > + block->bytes_used -= result->residue;
> > iio_dma_buffer_block_done(block);
> > }
> >
> > @@ -74,7 +76,7 @@ static int iio_dmaengine_buffer_submit_block(struct iio_dma_buffer_queue *queue,
> > if (!desc)
> > return -ENOMEM;
> >
> > - desc->callback = iio_dmaengine_buffer_block_done;
> > + desc->callback_result = iio_dmaengine_buffer_block_done;
> > desc->callback_param = block;
> >
> > cookie = dmaengine_submit(desc);
> > --
> > 2.20.1
> >
next prev parent reply other threads:[~2020-08-29 15:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-26 5:20 [PATCH] iio: buffer-dmaengine: adjust `bytes_used` with residue info Lars-Peter Clausen
2020-08-26 6:36 ` Alexandru Ardelean
2020-08-29 15:51 ` Jonathan Cameron [this message]
2020-08-29 18:30 ` Lars-Peter Clausen
2020-08-30 11:10 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200829165134.3361315a@archlinux \
--to=jic23@kernel.org \
--cc=alexandru.ardelean@analog.com \
--cc=ardeleanalex@gmail.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).