From: Jonathan Cameron <jic23@kernel.org>
To: Gene Chen <gene.chen.richtek@gmail.com>
Cc: matthias.bgg@gmail.com, knaack.h@gmx.de, lars@metafoo.de,
pmeerw@pmeerw.net, linux-iio@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
gene_chen@richtek.com, Wilma.Wu@mediatek.com,
shufan_lee@richtek.com, cy_huang@richtek.com,
benjamin.chao@mediatek.com
Subject: Re: [PATCH v3 2/2] Documentation: ABI: testing: mt6360: Add ADC sysfs guideline
Date: Sat, 29 Aug 2020 18:15:22 +0100 [thread overview]
Message-ID: <20200829181522.3664e1ce@archlinux> (raw)
In-Reply-To: <1598259985-12517-3-git-send-email-gene.chen.richtek@gmail.com>
On Mon, 24 Aug 2020 17:06:25 +0800
Gene Chen <gene.chen.richtek@gmail.com> wrote:
> From: Gene Chen <gene_chen@richtek.com>
>
> Add ABI documentation for mt6360 ADC sysfs interfaces.
Please check this. The actual filenames don't look correct
to me.
>
> Signed-off-by: Gene Chen <gene_chen@richtek.com>
> ---
> Documentation/ABI/testing/sysfs-bus-iio-adc-mt6360 | 83 ++++++++++++++++++++++
> 1 file changed, 83 insertions(+)
> create mode 100644 Documentation/ABI/testing/sysfs-bus-iio-adc-mt6360
>
> diff --git a/Documentation/ABI/testing/sysfs-bus-iio-adc-mt6360 b/Documentation/ABI/testing/sysfs-bus-iio-adc-mt6360
> new file mode 100644
> index 0000000..9dab17e
> --- /dev/null
> +++ b/Documentation/ABI/testing/sysfs-bus-iio-adc-mt6360
> @@ -0,0 +1,83 @@
> +What: /sys/bus/iio/devices/iio:deviceX/usbid_input
> +KernelVersion: 5.8.0
> +Contact: gene_chen@richtek.com
> +Description:
> + Indicated MT6360 USBID ADC
Can we give a bit of text saying what that is?
It's nice if people writing userspace software looking at this don't have
to go find the datasheet just to give a human readable description of the
channel.
> + Reading returns current voltage in uV
drop _current_ as that's a bit confusing :)
Reading returns voltage in uV
> +
> +What: /sys/bus/iio/devices/iio:deviceX/vbusdiv5_input
> +KernelVersion: 5.8.0
> +Contact: gene_chen@richtek.com
> +Description:
> + Indicated MT6360 VBUS ADC with high accuracy
> + Reading returns current voltage in uV
Is this measuring output of a regulator which has taken vbus and divided
it by 5? I'm rather confused.
> +
> +What: /sys/bus/iio/devices/iio:deviceX/vbusdiv2_input
> +KernelVersion: 5.8.0
> +Contact: gene_chen@richtek.com
> +Description:
> + Indicated MT6360 VBUS ADC with low accuracy
> + Reading returns current voltage in uV
> +
> +What: /sys/bus/iio/devices/iio:deviceX/vsys_input
> +KernelVersion: 5.8.0
> +Contact: gene_chen@richtek.com
> +Description:
> + Indicated MT6360 VSYS ADC
> + Reading returns current voltage in uV
> +
> +What: /sys/bus/iio/devices/iio:deviceX/vbat_input
> +KernelVersion: 5.8.0
> +Contact: gene_chen@richtek.com
> +Description:
> + Indicated MT6360 VBAT ADC
> + Reading returns current voltage in uV
> +
> +What: /sys/bus/iio/devices/iio:deviceX/ibus_input
> +KernelVersion: 5.8.0
> +Contact: gene_chen@richtek.com
> +Description:
> + Indicated MT6360 IBUS ADC
> + Reading returns current in uA
> +
> +What: /sys/bus/iio/devices/iio:deviceX/ibat_input
> +KernelVersion: 5.8.0
> +Contact: gene_chen@richtek.com
> +Description:
> + Indicated MT6360 IBAT ADC
> + Reading returns current in uA
> +
> +What: /sys/bus/iio/devices/iio:deviceX/chg_vddp_input
> +KernelVersion: 5.8.0
> +Contact: gene_chen@richtek.com
> +Description:
> + Indicated MT6360 CHG_VDDP ADC
> + Reading returns current voltage in uV
> +
> +What: /sys/bus/iio/devices/iio:deviceX/temp_jc_input
> +KernelVersion: 5.8.0
> +Contact: gene_chen@richtek.com
> +Description:
> + Indicated MT6360 IC junction temperature
> + Reading returns current temperature in degree
> +
> +What: /sys/bus/iio/devices/iio:deviceX/vref_ts_input
> +KernelVersion: 5.8.0
> +Contact: gene_chen@richtek.com
> +Description:
> + Indicated MT6360 VREF_TS ADC
> + Reading returns current voltage in uV
> +
> +What: /sys/bus/iio/devices/iio:deviceX/ts_input
> +KernelVersion: 5.8.0
> +Contact: gene_chen@richtek.com
> +Description:
> + Indicated MT6360 TS ADC
> + Reading returns current voltage in uV
> +
> +What: /sys/bus/iio/devices/iio:deviceX/timestamp
> +KernelVersion: 5.8.0
> +Contact: gene_chen@richtek.com
> +Description:
> + Indicated MT6360 timestamp
> + Reading returns current timestamp in ms
prev parent reply other threads:[~2020-08-29 17:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-24 9:06 [PATCH v3 0/2] iio: adc: mt6360: Add ADC driver for MT6360 Gene Chen
2020-08-24 9:06 ` [PATCH v3 1/2] " Gene Chen
2020-08-27 12:16 ` kernel test robot
2020-08-29 17:11 ` Jonathan Cameron
2020-09-08 6:17 ` Gene Chen
2020-09-08 7:43 ` Andy Shevchenko
2020-09-08 9:07 ` Jonathan Cameron
2020-09-08 11:08 ` Gene Chen
2020-09-08 12:58 ` Jonathan Cameron
2020-09-08 23:39 ` Gene Chen
2020-09-09 9:34 ` Jonathan Cameron
2020-09-10 0:14 ` Gene Chen
2020-08-30 17:39 ` Andy Shevchenko
2020-08-24 9:06 ` [PATCH v3 2/2] Documentation: ABI: testing: mt6360: Add ADC sysfs guideline Gene Chen
2020-08-29 17:15 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200829181522.3664e1ce@archlinux \
--to=jic23@kernel.org \
--cc=Wilma.Wu@mediatek.com \
--cc=benjamin.chao@mediatek.com \
--cc=cy_huang@richtek.com \
--cc=gene.chen.richtek@gmail.com \
--cc=gene_chen@richtek.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=pmeerw@pmeerw.net \
--cc=shufan_lee@richtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).