From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Dave Airlie <airlied@gmail.com>,
LKML <linux-kernel@vger.kernel.org>, <linux-iio@vger.kernel.org>
Subject: Re: aarch64 iio build error [PATCH]
Date: Tue, 1 Sep 2020 09:40:21 +0100 [thread overview]
Message-ID: <20200901094021.000068b2@Huawei.com> (raw)
In-Reply-To: <380f1b70-6575-5869-edf4-28842e818732@infradead.org>
On Fri, 28 Aug 2020 23:56:09 -0700
Randy Dunlap <rdunlap@infradead.org> wrote:
> On 8/24/20 12:39 PM, Dave Airlie wrote:
> > Hi Jonahtan,
> >
> > Since rc1 my aarch64 builds have been failing
> >
> > MODPOST Module.symvers
> > ERROR: modpost: "devm_iio_triggered_buffer_setup"
> > [drivers/iio/adc/rockchip_saradc.ko] undefined!
> > ERROR: modpost: "iio_trigger_notify_done"
> > [drivers/iio/adc/rockchip_saradc.ko] undefined!
> > ERROR: modpost: "iio_push_to_buffers"
> > [drivers/iio/adc/rockchip_saradc.ko] undefined!
> > make[2]: *** [/home/airlied/devel/kernel/dim/src/scripts/Makefile.modpost:111:
> > Module.symvers] Error
> >
> > Attached config.
> >
> > Dave.
>
> I haven't see any fixes for this, although I could have easily
> missed a patch.
>
> The patch below should fix these build errors.
Sorry. Badly timed vacation + waiting for end of merge window
due to some other stuff in the same pull request.
We had a number of fixes come in for this as a result.
https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git/commit/?h=fixes-togreg&id=e3ea4192d82480e1215280267746f51ce21db283
Is on it's way..
Jonathan
>
> ---
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix build errors in iio/rockchip_saradc by adding selects
> to drivers/iio/adc/Kconfig.
>
> Fixes these build errors:
>
> ERROR: modpost: "devm_iio_triggered_buffer_setup"
> [drivers/iio/adc/rockchip_saradc.ko] undefined!
> ERROR: modpost: "iio_trigger_notify_done"
> [drivers/iio/adc/rockchip_saradc.ko] undefined!
> ERROR: modpost: "iio_push_to_buffers"
> [drivers/iio/adc/rockchip_saradc.ko] undefined!
>
> Reported-by: Dave Airlie <airlied@gmail.com>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: jonathan.cameron@huawei.com
> ---
> drivers/iio/adc/Kconfig | 4 ++++
> 1 file changed, 4 insertions(+)
>
> --- linux-next-20200825.orig/drivers/iio/adc/Kconfig
> +++ linux-next-20200825/drivers/iio/adc/Kconfig
> @@ -865,6 +865,10 @@ config ROCKCHIP_SARADC
> tristate "Rockchip SARADC driver"
> depends on ARCH_ROCKCHIP || (ARM && COMPILE_TEST)
> depends on RESET_CONTROLLER
> + select IIO_BUFFER
> + select IIO_TRIGGER
> + select IIO_TRIGGERED_BUFFER
> + select IIO_TRIGGERED_EVENT
> help
> Say yes here to build support for the SARADC found in SoCs from
> Rockchip.
parent reply other threads:[~2020-09-01 8:42 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <380f1b70-6575-5869-edf4-28842e818732@infradead.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200901094021.000068b2@Huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=airlied@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).