From: Rob Herring <robh@kernel.org>
To: Jonathan Cameron <jic23@kernel.org>
Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Markus Pargmann <mpa@pengutronix.de>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>
Subject: Re: [PATCH v2 20/20] dt-bindings:iio:adc:fsl,imx25-gcq yaml conversion
Date: Tue, 15 Sep 2020 13:26:37 -0600 [thread overview]
Message-ID: <20200915192637.GA2351801@bogus> (raw)
In-Reply-To: <20200909175946.395313-21-jic23@kernel.org>
On Wed, Sep 09, 2020 at 06:59:46PM +0100, Jonathan Cameron wrote:
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> This binding has a few corners that would have been done different today
> but hopefully the yaml schema captures the constraints correctly.
>
> The child node names are not constrained hence the fairly open regexp.
> I've also documented the defaults for the two references that the
> driver seems to use and copied the value descriptions from the header
> because I think they should be in the dt-binding itself.
>
> This is part of a general effort to convert all the IIO bindings
> over to yaml
>
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Cc: Markus Pargmann <mpa@pengutronix.de>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
> ---
> .../bindings/iio/adc/fsl,imx25-gcq.txt | 57 --------
> .../bindings/iio/adc/fsl,imx25-gcq.yaml | 129 ++++++++++++++++++
> 2 files changed, 129 insertions(+), 57 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/fsl,imx25-gcq.txt b/Documentation/devicetree/bindings/iio/adc/fsl,imx25-gcq.txt
> deleted file mode 100644
> index eebdcec3dab5..000000000000
> --- a/Documentation/devicetree/bindings/iio/adc/fsl,imx25-gcq.txt
> +++ /dev/null
> @@ -1,57 +0,0 @@
> -Freescale i.MX25 ADC GCQ device
> -
> -This is a generic conversion queue device that can convert any of the
> -analog inputs using the ADC unit of the i.MX25.
> -
> -Required properties:
> - - compatible: Should be "fsl,imx25-gcq".
> - - reg: Should be the register range of the module.
> - - interrupts: Should be the interrupt number of the module.
> - Typically this is <1>.
> - - #address-cells: Should be <1> (setting for the subnodes)
> - - #size-cells: Should be <0> (setting for the subnodes)
> -
> -Optional properties:
> - - vref-ext-supply: The regulator supplying the ADC reference voltage.
> - Required when at least one subnode uses the this reference.
> - - vref-xp-supply: The regulator supplying the ADC reference voltage on pin XP.
> - Required when at least one subnode uses this reference.
> - - vref-yp-supply: The regulator supplying the ADC reference voltage on pin YP.
> - Required when at least one subnode uses this reference.
> -
> -Sub-nodes:
> -Optionally you can define subnodes which define the reference voltage
> -for the analog inputs.
> -
> -Required properties for subnodes:
> - - reg: Should be the number of the analog input.
> - 0: xp
> - 1: yp
> - 2: xn
> - 3: yn
> - 4: wiper
> - 5: inaux0
> - 6: inaux1
> - 7: inaux2
> -Optional properties for subnodes:
> - - fsl,adc-refp: specifies the positive reference input as defined in
> - <dt-bindings/iio/adc/fsl-imx25-gcq.h>
> - - fsl,adc-refn: specifies the negative reference input as defined in
> - <dt-bindings/iio/adc/fsl-imx25-gcq.h>
> -
> -Example:
> -
> - adc: adc@50030800 {
> - compatible = "fsl,imx25-gcq";
> - reg = <0x50030800 0x60>;
> - interrupt-parent = <&tscadc>;
> - interrupts = <1>;
> - #address-cells = <1>;
> - #size-cells = <0>;
> -
> - inaux@5 {
> - reg = <5>;
> - fsl,adc-refp = <MX25_ADC_REFP_INT>;
> - fsl,adc-refn = <MX25_ADC_REFN_NGND>;
> - };
> - };
> diff --git a/Documentation/devicetree/bindings/iio/adc/fsl,imx25-gcq.yaml b/Documentation/devicetree/bindings/iio/adc/fsl,imx25-gcq.yaml
> new file mode 100644
> index 000000000000..6c4e3ef0862c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/adc/fsl,imx25-gcq.yaml
> @@ -0,0 +1,129 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/adc/fsl,imx25-gcq.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Freescale ADC GCQ device
> +
> +description:
> + This is a generic conversion queue device that can convert any of the
> + analog inputs using the ADC unit of the i.MX25.
> +
> +maintainers:
> + - Markus Pargmann <mpa@pengutronix.de>
> +
> +properties:
> + compatible:
> + const: fsl,imx25-gcq
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + vref-ext-supply:
> + description:
> + The regulator supplying the ADC reference voltage.
> + Required when at least one subnode uses the this reference.
> +
> + vref-xp-supply:
> + description:
> + The regulator supplying the ADC reference voltage on pin XP.
> + Required when at least one subnode uses this reference.
> +
> + vref-yp-supply:
> + description:
> + The regulator supplying the ADC reference voltage on pin YP.
> + Required when at least one subnode uses this reference.
> +
> + "#io-channel-cells":
> + const: 1
> +
> + "#address-cells":
> + const: 1
> +
> + "#size-cells":
> + const: 0
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - "#address-cells"
> + - "#size-cells"
> +
> +patternProperties:
> + "[a-z][a-z0-9]+@[0-9a-f]+$":
> + type: object
> + description:
> + Child nodes used to define the reference voltages used for each channel
> +
> + properties:
> + reg:
> + description: |
> + Number of the analog input.
> + 0: xp
> + 1: yp
> + 2: xn
> + 3: yn
> + 4: wiper
> + 5: inaux0
> + 6: inaux1
> + 7: inaux2
> + items:
> + - minimum: 0
> + maximum: 7
> +
> + fsl,adc-refp:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description: |
> + Specifies the positive reference input as defined in
> + <dt-bindings/iio/adc/fsl-imx25-gcq.h>
> + 0: YP voltage reference
> + 1: XP voltage reference
> + 2: External voltage reference
> + 3: Internal voltage reference (default)
> + minimum: 0
> + maximum: 3
> +
> + fsl,adc-refn:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description: |
> + Specifies the negative reference input as defined in
> + <dt-bindings/iio/adc/fsl-imx25-gcq.h>
> + 0: XN ground reference
> + 1: YN ground reference
> + 2: Internal ground reference
> + 3: External ground reference (default)
> + minimum: 0
> + maximum: 3
> +
> + required:
> + - reg
Each level needs 'additionalProperties':
additionalProperties: false
With that,
Reviewed-by: Rob Herring <robh@kernel.org>
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/iio/adc/fsl-imx25-gcq.h>
> + soc {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + adc@50030800 {
> + compatible = "fsl,imx25-gcq";
> + reg = <0x50030800 0x60>;
> + interrupt-parent = <&tscadc>;
> + interrupts = <1>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + inaux@5 {
> + reg = <5>;
> + fsl,adc-refp = <MX25_ADC_REFP_INT>;
> + fsl,adc-refn = <MX25_ADC_REFN_NGND>;
> + };
> + };
> + };
> +...
> --
> 2.28.0
>
next prev parent reply other threads:[~2020-09-15 19:28 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-09 17:59 [PATCH v2 00/20] dt-bindings:iio:adc: Another set of yaml conversions Jonathan Cameron
2020-09-09 17:59 ` [PATCH v2 01/20] dt-bindings:iio:adc:fsl,vf610-adc conversion to yaml Jonathan Cameron
2020-09-15 19:00 ` Rob Herring
2020-09-15 20:45 ` Rob Herring
2020-09-16 10:34 ` Jonathan Cameron
2020-09-17 2:24 ` Andy Duan
2020-09-19 13:33 ` Jonathan Cameron
2020-09-09 17:59 ` [PATCH v2 02/20] dt-bindings:iio:adc:ti,twl4030-madc yaml conversion Jonathan Cameron
2020-09-15 19:01 ` Rob Herring
2020-09-19 13:42 ` Jonathan Cameron
2020-09-09 17:59 ` [PATCH v2 03/20] dt-bindings:iio:adc:st,stmpe-adc " Jonathan Cameron
2020-09-15 19:02 ` Rob Herring
2020-09-19 13:44 ` Jonathan Cameron
2020-09-09 17:59 ` [PATCH v2 04/20] dt-bindings:iio:adc: aspeed,ast2400 " Jonathan Cameron
2020-09-10 2:32 ` Joel Stanley
2020-09-16 10:36 ` Jonathan Cameron
2020-09-16 12:39 ` Joel Stanley
2020-09-16 14:17 ` Jonathan Cameron
2020-09-19 13:47 ` Jonathan Cameron
2020-09-19 13:52 ` Jonathan Cameron
2020-09-15 19:03 ` Rob Herring
2020-09-09 17:59 ` [PATCH v2 05/20] dt-bindings:iio:adc:marvell,berlin2-adc " Jonathan Cameron
2020-09-15 19:04 ` Rob Herring
2020-09-19 13:55 ` Jonathan Cameron
2020-09-09 17:59 ` [PATCH v2 06/20] dt-bindings:iio:adc:sprd,sc2720-adc " Jonathan Cameron
2020-09-15 19:05 ` Rob Herring
2020-09-19 13:57 ` Jonathan Cameron
2020-09-09 17:59 ` [PATCH v2 07/20] dt-bindings:iio:adc:nuvoton,nau7802 " Jonathan Cameron
2020-09-09 19:19 ` Alexandre Belloni
2020-09-10 7:57 ` Jonathan Cameron
2020-09-15 19:06 ` Rob Herring
2020-09-19 14:01 ` Jonathan Cameron
2020-09-09 17:59 ` [PATCH v2 08/20] dt-bindings:iio:adc:nuvoton,npcm750-adc " Jonathan Cameron
2020-09-15 19:07 ` Rob Herring
2020-09-19 14:03 ` Jonathan Cameron
2020-09-09 17:59 ` [PATCH v2 09/20] dt-bindings:iio:adc:nxp,lpc1850-adc " Jonathan Cameron
2020-09-15 19:07 ` Rob Herring
2020-09-19 14:20 ` Jonathan Cameron
2020-09-09 17:59 ` [PATCH v2 10/20] dt-bindings:iio:adc:lpc3220-adc " Jonathan Cameron
2020-09-15 19:09 ` Rob Herring
2020-09-19 14:22 ` Jonathan Cameron
2020-09-09 17:59 ` [PATCH v2 11/20] dt-bindings:iio:adc:motorola,cpcap-adc " Jonathan Cameron
2020-09-15 19:11 ` Rob Herring
2020-09-19 14:25 ` Jonathan Cameron
2020-09-09 17:59 ` [PATCH v2 12/20] dt-bindings:iio:adc:dlg,da9150-gpadc " Jonathan Cameron
2020-09-15 19:12 ` Rob Herring
2020-09-19 14:57 ` Jonathan Cameron
2020-09-09 17:59 ` [PATCH v2 13/20] dt-bindings:iio:adc:cosmic,10001-adc " Jonathan Cameron
2020-09-15 19:13 ` Rob Herring
2020-09-19 14:07 ` Jonathan Cameron
2020-09-09 17:59 ` [PATCH v2 14/20] dt-bindings:iio:adc:adi,ad7949 " Jonathan Cameron
2020-09-15 19:13 ` Rob Herring
2020-09-19 14:59 ` Jonathan Cameron
2020-09-09 17:59 ` [PATCH v2 15/20] dt-bindings:iio:adc:ad7768-1 " Jonathan Cameron
2020-09-15 19:15 ` Rob Herring
2020-09-19 15:01 ` Jonathan Cameron
2020-09-09 17:59 ` [PATCH v2 16/20] dt-bindings:iio:adc:ti,ads1015 " Jonathan Cameron
2020-09-15 19:16 ` Rob Herring
2020-09-19 14:12 ` Jonathan Cameron
2020-09-09 17:59 ` [PATCH v2 17/20] dt-bindings:iio:adc:holt,hi8435 " Jonathan Cameron
2020-09-15 19:17 ` Rob Herring
2020-09-19 15:03 ` Jonathan Cameron
2020-09-09 17:59 ` [PATCH v2 18/20] dt-bindings:iio:adc:amlogic,meson-saradc " Jonathan Cameron
2020-09-15 19:23 ` Rob Herring
2020-09-15 19:31 ` Martin Blumenstingl
2020-09-09 17:59 ` [PATCH v2 19/20] dt-bindings:iio:adc:fsl,imx7d-adc " Jonathan Cameron
2020-09-15 19:24 ` Rob Herring
2020-09-16 10:27 ` Jonathan Cameron
2020-09-19 14:14 ` Jonathan Cameron
2020-09-09 17:59 ` [PATCH v2 20/20] dt-bindings:iio:adc:fsl,imx25-gcq " Jonathan Cameron
2020-09-15 19:26 ` Rob Herring [this message]
2020-09-16 10:33 ` Jonathan Cameron
2020-09-16 10:38 ` Jonathan Cameron
2020-09-19 14:19 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200915192637.GA2351801@bogus \
--to=robh@kernel.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=mpa@pengutronix.de \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).