Re: [PATCH] iio:magn:hmc5843: Fix passing true where iio_shared_by enum required.

From: Jonathan Cameron <jic23@kernel.org>
To: Matt Ranostay <matt.ranostay@konsulko.com>
Cc: "open list:IIO SUBSYSTEM AND DRIVERS" <linux-iio@vger.kernel.org>,
	Jonathan Cameron <Jonathan.Cameron@huawei.com>,
	"H . Nikolaus Schaller" <hns@goldelico.com>
Subject: Re: [PATCH] iio:magn:hmc5843: Fix passing true where iio_shared_by enum required.
Date: Sat, 19 Sep 2020 13:10:49 +0100	[thread overview]
Message-ID: <20200919131049.24dfaa15@archlinux> (raw)
In-Reply-To: <CAJCx=g=wrvEaE-Pwuy0KmtSux8Sgeiu9p3EfHdfwCV4xQGGUKw@mail.gmail.com>

On Fri, 18 Sep 2020 12:15:20 -0700
Matt Ranostay <matt.ranostay@konsulko.com> wrote:

> On Sun, Sep 13, 2020 at 4:27 AM Jonathan Cameron <jic23@kernel.org> wrote:
> >
> > From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> >
> > So it's obvious that the code is wrong in passing true, but I'm assuming
> > that will actually evaluate to 1 and hence IIO_SHARED_BY_TYPE.
> > The documentation however has this attribute as IIO_SHARED_BY_ALL.
> > My current assumption is the documentation is wrong.
> > If anyone knows otherwise please shout out!
> >  
> 
> Yeah this is much easier to understand than the odd boolean value.
> 
> Reviewed-by: Matt Ranostay <matt.ranostay@konsulko.com>
> 
Thanks all.

Applied to the togreg branch of iio.git. I've not marked it for
stable as it has no functional affect.

Jonathan

> > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > Fixes: 7247645f6865 ("iio: hmc5843: Move hmc5843 out of staging")
> > Cc: H. Nikolaus Schaller <hns@goldelico.com>
> > ---
> >  drivers/iio/magnetometer/hmc5843_core.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/iio/magnetometer/hmc5843_core.c b/drivers/iio/magnetometer/hmc5843_core.c
> > index 1474ba63babe..780faea61d82 100644
> > --- a/drivers/iio/magnetometer/hmc5843_core.c
> > +++ b/drivers/iio/magnetometer/hmc5843_core.c
> > @@ -245,7 +245,7 @@ static const struct iio_enum hmc5843_meas_conf_enum = {
> >  };
> >
> >  static const struct iio_chan_spec_ext_info hmc5843_ext_info[] = {
> > -       IIO_ENUM("meas_conf", true, &hmc5843_meas_conf_enum),
> > +       IIO_ENUM("meas_conf", IIO_SHARED_BY_TYPE, &hmc5843_meas_conf_enum),
> >         IIO_ENUM_AVAILABLE("meas_conf", &hmc5843_meas_conf_enum),
> >         IIO_MOUNT_MATRIX(IIO_SHARED_BY_DIR, hmc5843_get_mount_matrix),
> >         { }
> > @@ -259,7 +259,7 @@ static const struct iio_enum hmc5983_meas_conf_enum = {
> >  };
> >
> >  static const struct iio_chan_spec_ext_info hmc5983_ext_info[] = {
> > -       IIO_ENUM("meas_conf", true, &hmc5983_meas_conf_enum),
> > +       IIO_ENUM("meas_conf", IIO_SHARED_BY_TYPE, &hmc5983_meas_conf_enum),
> >         IIO_ENUM_AVAILABLE("meas_conf", &hmc5983_meas_conf_enum),
> >         IIO_MOUNT_MATRIX(IIO_SHARED_BY_DIR, hmc5843_get_mount_matrix),
> >         { }
> > --
> > 2.28.0
> >  