From: Jonathan Cameron <jic23@kernel.org>
To: Michael Auchter <michael.auchter@ni.com>
Cc: Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Rob Herring <robh+dt@kernel.org>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] dt-bindings: iio: dac: ad5686: add binding
Date: Wed, 23 Sep 2020 21:15:52 +0100 [thread overview]
Message-ID: <20200923211552.3532afdb@archlinux> (raw)
In-Reply-To: <20200922184012.557622-3-michael.auchter@ni.com>
On Tue, 22 Sep 2020 13:40:12 -0500
Michael Auchter <michael.auchter@ni.com> wrote:
> Add a binding for AD5686
>
> Signed-off-by: Michael Auchter <michael.auchter@ni.com>
Hi Michael,
Thanks for this.
A few comments inline.
Thanks,
Jonathan
> ---
> Changes since v1:
> - Keep supported device sorted
> - fix adc -> dac type in schema path
>
> .../bindings/iio/dac/adi,ad5686.yaml | 61 +++++++++++++++++++
> 1 file changed, 61 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml
>
> diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml b/Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml
> new file mode 100644
> index 000000000000..9ce76d75f31b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml
> @@ -0,0 +1,61 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/dac/adi,ad5686.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Analog Devices AD5686 and similar multi-channel DACs
> +
> +maintainers:
> + - Michael Auchter <michael.auchter@ni.com>
> +
> +description: |
> + Binding for Analog Devices AD5686 and similar multi-channel DACs
> +
> +properties:
> + compatible:
> + enum:
> + - adi,ad5311r
> + - adi,ad5338r
> + - adi,ad5671r
> + - adi,ad5675r
> + - adi,ad5691r
> + - adi,ad5692r
> + - adi,ad5693
> + - adi,ad5693r
> + - adi,ad5694
> + - adi,ad5694r
> + - adi,ad5695r
> + - adi,ad5696
> + - adi,ad5696r
> +
> + reg:
> + maxItems: 1
> +
> + vcc-supply:
> + description: |
> + The regulator supply for DAC reference voltage.
> +
> + '#address-cells':
> + const: 1
> +
> + '#size-cells':
> + const: 0
Why address-cells and size-cells? Properties we are giving
are for the dac, not the i2c bus.
> +
> +required:
> + - compatible
> + - reg
additionalProperties: false
> +
> +examples:
> + - |
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + ad5686: dac@0 {
> + compatible = "adi,ad5686";
> + reg = <0>;
> + vcc-supply = <&dac_vref>;
> + };
> + };
> +
next prev parent reply other threads:[~2020-09-23 20:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-22 18:40 [PATCH v2 1/3] iio: dac: ad5686: add support for AD5338R Michael Auchter
2020-09-22 18:40 ` [PATCH v2 2/3] iio: dac: ad5686: add of_match_table Michael Auchter
2020-09-22 18:40 ` [PATCH v2 3/3] dt-bindings: iio: dac: ad5686: add binding Michael Auchter
2020-09-23 20:15 ` Jonathan Cameron [this message]
2020-09-23 20:18 ` [PATCH v2 1/3] iio: dac: ad5686: add support for AD5338R Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200923211552.3532afdb@archlinux \
--to=jic23@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.auchter@ni.com \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).