From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Mark Pearson <markpearson@lenovo.com>,
linux-iio@vger.kernel.org, Bastien Nocera <hadess@hadess.net>,
Nitin Joshi1 <njoshi1@lenovo.com>,
linux-input@vger.kernel.org
Subject: Re: [External] Using IIO to export laptop palm-sensor and lap-mode info to userspace?
Date: Thu, 12 Nov 2020 22:58:32 -0800 [thread overview]
Message-ID: <20201113065832.GD356503@dtor-ws> (raw)
In-Reply-To: <3568c492-d9bd-c02d-4cbc-7f3eef605ef5@redhat.com>
On Thu, Nov 12, 2020 at 10:50:12AM +0100, Hans de Goede wrote:
> Hi,
>
> On 11/12/20 7:23 AM, Dmitry Torokhov wrote:
> > On Wed, Oct 07, 2020 at 11:51:05AM +0200, Hans de Goede wrote:
> >> Hi,
> >>
> >> On 10/7/20 10:36 AM, Jonathan Cameron wrote:
> >>> On Mon, 5 Oct 2020 22:04:27 -0400
> >>> Mark Pearson <markpearson@lenovo.com> wrote:
> >>>
> >>>> Adding Nitin, lead for this feature, to the thread
> >>>
> >>> +CC linux-input and Dmitry for reasons that will become clear below.
> >>>>
> >>>> On 2020-10-03 10:02 a.m., Hans de Goede wrote:
> >>>>> Hi All,
> >>>>>
> >>>>> Modern laptops can have various sensors which are kinda
> >>>>> like proximity sensors, but not really (they are more
> >>>>> specific in which part of the laptop the user is
> >>>>> proximate to).
> >>>>>
> >>>>> Specifically modern Thinkpad's have 2 readings which we
> >>>>> want to export to userspace, and I'm wondering if we
> >>>>> could use the IIO framework for this since these readings
> >>>>> are in essence sensor readings:
> >>>>>
> >>>>> 1. These laptops have a sensor in the palm-rests to
> >>>>> check if a user is physically proximate to the device's
> >>>>> palm-rests. This info will be used by userspace for WWAN
> >>>>> functionality to control the transmission level safely.
> >>>>>
> >>>>> A patch adding a thinkpad_acpi specific sysfs API for this
> >>>>> is currently pending:
> >>>>> https://patchwork.kernel.org/patch/11722127/
> >>>>>
> >>>>> But I'm wondering if it would not be better to use
> >>>>> IIO to export this info.
> >>>
> >>> My first thought on this is it sounds more like a key than a sensor
> >>> (simple proximity sensors fall into this category as well.)
> >
> > [ sorry for sitting on this thread for so long ]
> >
> > So I think the important question here is if we only ever want yes/no
> > answer, or if we can consider adjusting behavior of the system based on
> > the "closeness" of an object to the device, in which case I think IIO is
> > more flexible.
> >
> > FWIW in Chrome OS land we name IIO proximity sensors using a scheme
> > "proximity-lte", "proximity-wifi", "proximity-wifi-left",
> > "proximity-wifi-right", etc, and then userspace implements various
> > policies (SAR, etc) based off it.
>
> Interesting, so 2 questions:
>
> 1. So your encoding the location in the sensor's parent-device name
> instead of using a new sysfs attribute for this ?
I think it depends on the kernel we use and architecture. On x86 I think
we rely on udev, like this:
https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/master/overlay-nocturne/chromeos-base/chromeos-bsp-nocturne/files/udev/99-cros-sx-proximity.rules
DEVPATH=="*/pci0000:00/0000:00:15.1/*", SYMLINK+="proximity-wifi-right"
DEVPATH=="*/pci0000:00/0000:00:19.1/*", SYMLINK+="proximity-wifi-left"
ATTR{events/in_proximity1_USE_CS1_thresh_either_en}="1"
On newer ARM we use "label" attribute in DTS:
arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
ap_sar_sensor: proximity@28 {
compatible = "semtech,sx9310";
reg = <0x28>;
#io-channel-cells = <1>;
pinctrl-names = "default";
pinctrl-0 = <&p_sensor_int_l>;
interrupt-parent = <&tlmm>;
interrupts = <24 IRQ_TYPE_LEVEL_LOW>;
vdd-supply = <&pp3300_a>;
svdd-supply = <&pp1800_prox>;
status = "disabled";
label = "proximity-wifi";
};
>
> 2. Do these sensors just give a boolean value atm, or do they already
> report a range ? IIRC one of the objections from the iio folks in
> the Lenovo case was that booleans are not really a good fit for iio
> (IIRC they also said we could still use iio for this).
One of the sensors we use is sx9310 that I believe can report range, but
I think we configure them to trigger when a threshold is crossed.
Events are handled by our powerd:
https://chromium.googlesource.com/chromiumos/platform2/+/master/power_manager/powerd/system/sar_watcher.cc
>
> Perhaps you can provide an URL to the kernel code implementing these ?
drivers/iio/proximity/sx9310.c
Also sx932x - https://lore.kernel.org/patchwork/patch/1005708/
Thanks.
--
Dmitry
next prev parent reply other threads:[~2020-11-13 6:58 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-03 14:02 Using IIO to export laptop palm-sensor and lap-mode info to userspace? Hans de Goede
2020-10-06 2:04 ` [External] " Mark Pearson
2020-10-07 8:36 ` Jonathan Cameron
2020-10-07 9:51 ` Hans de Goede
2020-10-07 11:35 ` Bastien Nocera
2020-10-07 13:08 ` Hans de Goede
2020-10-07 13:29 ` Bastien Nocera
2020-10-07 13:32 ` Hans de Goede
2020-10-08 0:14 ` Jeff LaBundy
2020-10-08 7:10 ` Hans de Goede
2020-10-09 2:19 ` Jeff LaBundy
2020-10-12 12:13 ` Hans de Goede
2020-10-12 12:36 ` Enrico Weigelt, metux IT consult
2020-10-13 1:12 ` Mark Pearson
2020-10-13 8:38 ` Hans de Goede
2020-11-12 6:23 ` Dmitry Torokhov
2020-11-12 9:50 ` Hans de Goede
2020-11-13 6:58 ` Dmitry Torokhov [this message]
2020-11-19 15:39 ` Hans de Goede
2020-11-19 16:11 ` Bastien Nocera
2020-11-20 9:59 ` Jonathan Cameron
2020-11-23 12:16 ` Hans de Goede
2020-11-23 16:07 ` Jonathan Cameron
2020-11-19 15:16 ` Bastien Nocera
2020-11-19 15:24 ` Hans de Goede
2020-11-19 15:58 ` Bastien Nocera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201113065832.GD356503@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=hadess@hadess.net \
--cc=hdegoede@redhat.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=markpearson@lenovo.com \
--cc=njoshi1@lenovo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).