linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Peter Rosin <peda@axentia.se>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	linux-iio <linux-iio@vger.kernel.org>,
	Hartmut Knaack <knaack.h@gmx.de>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Peter Meerwald-Stadler <pmeerw@pmeerw.net>
Subject: Re: [PATCH] iio: afe: iio-rescale: Support processed channels
Date: Sun, 13 Dec 2020 12:16:15 +0000	[thread overview]
Message-ID: <20201213121615.55a86f77@archlinux> (raw)
In-Reply-To: <435ebb1b-431c-fdeb-023e-39c6f6102e22@axentia.se>

On Sun, 13 Dec 2020 00:22:17 +0100
Peter Rosin <peda@axentia.se> wrote:

> On 2020-12-12 13:26, Linus Walleij wrote:
> > On Mon, Nov 2, 2020 at 12:22 AM Linus Walleij <linus.walleij@linaro.org> wrote:
> >   
> >> It happens that an ADC will only provide raw or processed
> >> voltage conversion channels. (adc/ab8500-gpadc.c).
> >> On the Samsung GT-I9070 this is used for a light sensor
> >> and current sense amplifier so we need to think of something.
> >>
> >> The idea is to allow processed channels and scale them
> >> with 1/1 and then the rescaler can modify the result
> >> on top.
> >>
> >> Cc: Peter Rosin <peda@axentia.se>
> >> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>  
> > 
> > Did we reach any conclusion on this? I really need to use
> > the rescaler on an ADC that only handles processed channels...
> > 
> > I'm sorry that I can't make this ADC disappear :D  
> 
> Hi!
> 
> My conclusion was that the patch is buggy since it presents inconsistent
> information. That needs to be fixed one way or the other. If the offending
> information cannot be filtered out for some reason, I don't know what to
> do. Details in my previous comment [1]. BTW, I still do not know the answer
> to the .read_avail question at the end of that message, and I don't have
> time to dig into it. Sorry.

Unless I'm missing something, I think it presents no information unless
we strangely have a driver providing read_avail for _RAW but only
_PROCESSED channels which is a bug.  I'm not that bothered about
missing information in this particular, somewhat obscure, corner case.

So I think we should take the patch as it stands.  It's missed the
merge window now anyway unfortunately.  So Peter, I would suggest we
take this and perhaps revisit to tidy up loose corners when we all have
more time.

Thanks,

Jonathan


> 
> Cheers,
> Peter
> 
> [1] https://lore.kernel.org/linux-iio/320464d8-659c-01de-0e08-34e4c744ef16@axentia.se/


  reply	other threads:[~2020-12-13 12:17 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-01 23:22 [PATCH] iio: afe: iio-rescale: Support processed channels Linus Walleij
2020-11-15 11:21 ` Linus Walleij
2020-11-15 17:44 ` Jonathan Cameron
2020-11-16  8:18   ` Peter Rosin
2020-12-13 12:12     ` Jonathan Cameron
2020-12-12 12:26 ` Linus Walleij
2020-12-12 23:22   ` Peter Rosin
2020-12-13 12:16     ` Jonathan Cameron [this message]
2020-12-14  8:34       ` Peter Rosin
2020-12-14 15:07         ` Jonathan Cameron
2020-12-14 15:30           ` Peter Rosin
2020-12-14 16:34             ` Jonathan Cameron
2021-01-04 14:45               ` Linus Walleij
2021-01-04 17:11                 ` Jonathan Cameron
2021-01-04 18:09                   ` Peter Rosin
2020-12-13 15:16 ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201213121615.55a86f77@archlinux \
    --to=jic23@kernel.org \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linus.walleij@linaro.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=peda@axentia.se \
    --cc=pmeerw@pmeerw.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).