From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Jonathan Cameron <jic23@kernel.org>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Himanshu Jha <himanshujha199640@gmail.com>,
linux-iio@vger.kernel.org
Subject: Re: [PATCH 1/3] iio: vl6180: Use DIV_ROUND_CLOSEST() instead of open-coding it
Date: Mon, 28 Dec 2020 11:28:30 +0530 [thread overview]
Message-ID: <20201228055830.GA9634@thinkpad> (raw)
In-Reply-To: <20201227171126.28216-1-lars@metafoo.de>
On Sun, Dec 27, 2020 at 06:11:24PM +0100, Lars-Peter Clausen wrote:
> Use DIV_ROUND_CLOSEST() instead of open-coding it. This documents intent
> and makes it more clear what is going on for the casual reviewer.
>
> Generated using the following the Coccinelle semantic patch.
>
> // <smpl>
> @r1@
> expression x;
> constant C1;
> constant C2;
> @@
> ((x) + C1) / C2
>
> @script:python@
> C1 << r1.C1;
> C2 << r1.C2;
> @@
> try:
> if int(C1) * 2 != int(C2):
> cocci.include_match(False)
> except:
> cocci.include_match(False)
>
> @@
> expression r1.x;
> constant r1.C1;
> constant r1.C2;
> @@
> -(((x) + C1) / C2)
> +DIV_ROUND_CLOSEST(x, C2)
> // </smpl>
>
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>
Thanks,
Mani
> ---
> drivers/iio/light/vl6180.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/light/vl6180.c b/drivers/iio/light/vl6180.c
> index 4775bd785e50..d47a4f6f4e87 100644
> --- a/drivers/iio/light/vl6180.c
> +++ b/drivers/iio/light/vl6180.c
> @@ -392,7 +392,7 @@ static int vl6180_set_it(struct vl6180_data *data, int val, int val2)
> {
> int ret, it_ms;
>
> - it_ms = (val2 + 500) / 1000; /* round to ms */
> + it_ms = DIV_ROUND_CLOSEST(val2, 1000); /* round to ms */
> if (val != 0 || it_ms < 1 || it_ms > 512)
> return -EINVAL;
>
> --
> 2.20.1
>
next prev parent reply other threads:[~2020-12-28 5:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-27 17:11 [PATCH 1/3] iio: vl6180: Use DIV_ROUND_CLOSEST() instead of open-coding it Lars-Peter Clausen
2020-12-27 17:11 ` [PATCH 2/3] iio: bme680: " Lars-Peter Clausen
2020-12-27 17:11 ` [PATCH 3/3] iio: tsl2583: " Lars-Peter Clausen
2020-12-28 5:58 ` Manivannan Sadhasivam [this message]
2020-12-29 13:58 ` [PATCH 1/3] iio: vl6180: " Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201228055830.GA9634@thinkpad \
--to=manivannan.sadhasivam@linaro.org \
--cc=himanshujha199640@gmail.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).