From: Jonathan Cameron <jic23@kernel.org>
To: Gwendal Grignou <gwendal@chromium.org>
Cc: Stephen Boyd <swboyd@chromium.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-iio <linux-iio@vger.kernel.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Benson Leung <bleung@chromium.org>,
Guenter Roeck <groeck@chromium.org>,
Douglas Anderson <dianders@chromium.org>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>
Subject: Re: [PATCH v6 3/3] iio: proximity: Add a ChromeOS EC MKBP proximity driver
Date: Sat, 13 Mar 2021 14:57:04 +0000 [thread overview]
Message-ID: <20210313145704.46775626@archlinux> (raw)
In-Reply-To: <CAPUE2uu90ySZu6iyanakBZ+Oy-1YSTaHwBaeZdnUxK3ncW9BZA@mail.gmail.com>
On Fri, 12 Mar 2021 13:23:35 -0800
Gwendal Grignou <gwendal@chromium.org> wrote:
> On Sun, Feb 21, 2021 at 7:53 AM Jonathan Cameron <jic23@kernel.org> wrote:
> >
> > On Sun, 14 Feb 2021 12:39:58 -0800
> > Stephen Boyd <swboyd@chromium.org> wrote:
> >
> > > Quoting Jonathan Cameron (2021-02-14 04:48:09)
> > > > On Wed, 10 Feb 2021 18:46:01 -0800
> > > > Stephen Boyd <swboyd@chromium.org> wrote:
> > > >
> > > > > Add support for a ChromeOS EC proximity driver that exposes a "front"
> > > > > proximity sensor via the IIO subsystem. The EC decides when front
> > > > > proximity is near and sets an MKBP switch 'EC_MKBP_FRONT_PROXIMITY' to
> > > > > notify the kernel of proximity. Similarly, when proximity detects
> > > > > something far away it sets the switch bit to 0. For now this driver
> > > > > exposes a single sensor, but it could be expanded in the future via more
> > > > > MKBP bits if desired.
> > > > >
> > > > > Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> > > > > Cc: Benson Leung <bleung@chromium.org>
> > > > > Cc: Guenter Roeck <groeck@chromium.org>
> > > > > Cc: Douglas Anderson <dianders@chromium.org>
> > > > > Cc: Gwendal Grignou <gwendal@chromium.org>
> > > > > Reviewed-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> > > > > Signed-off-by: Stephen Boyd <swboyd@chromium.org>
> > > >
> > > > I'm fine with this, but want to leave a little time for others to take
> > > > one last look. We've missed the coming merge window now anyway.
> > > >
> > > > If I seem to have forgotten this in a couple of weeks, feel free to
> > > > give me a bump.
> > > >
> > >
> > > Ok no problem. Gwendal had some comments on v5 that may be applicable
> > > here too but I think they mostly mean that the resume handler may not be
> > > needed if cros ec is fixed. Having the resume handler shouldn't hurt
> > > though unless I missed something. Gwendal?
> >
> > @Gwendal, could you take a quick glance at this, or alternatively let
> > us know if you need more time to get to it.
> It will work as is.
>
> Reviewed-by: Gwendal Grignou <gwendal@chromium.org>
Applied to the togreg branch of iio.git. My local build test highlighted
a much older kernel-doc naming issue so I've sent out a patch to tidy that
up whilst we are here.
Thanks,
Jonathan
> >
> > Thanks,
> >
> > Jonathan
> >
> >
prev parent reply other threads:[~2021-03-13 14:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-11 2:45 [PATCH v6 0/3] iio: Add a ChromeOS EC MKBP proximity driver Stephen Boyd
2021-02-11 2:45 ` [PATCH v6 1/3] platform/chrome: cros_ec: Add SW_FRONT_PROXIMITY MKBP define Stephen Boyd
2021-02-11 2:46 ` [PATCH v6 2/3] dt-bindings: iio: Add cros ec proximity yaml doc Stephen Boyd
2021-02-11 2:46 ` [PATCH v6 3/3] iio: proximity: Add a ChromeOS EC MKBP proximity driver Stephen Boyd
2021-02-14 12:48 ` Jonathan Cameron
2021-02-14 20:39 ` Stephen Boyd
2021-02-21 15:53 ` Jonathan Cameron
2021-03-12 21:23 ` Gwendal Grignou
2021-03-13 14:57 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210313145704.46775626@archlinux \
--to=jic23@kernel.org \
--cc=bleung@chromium.org \
--cc=dianders@chromium.org \
--cc=dmitry.torokhov@gmail.com \
--cc=enric.balletbo@collabora.com \
--cc=groeck@chromium.org \
--cc=gwendal@chromium.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).