linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: linux-iio@vger.kernel.org
Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com>,
	kbuild test robot <lkp@intel.com>
Subject: Re: [PATCH] iio:cdc:ad7150: Fix use of uninitialized ret
Date: Tue, 6 Apr 2021 09:44:05 +0100	[thread overview]
Message-ID: <20210406094405.148dacea@jic23-huawei> (raw)
In-Reply-To: <20210406083244.649984-1-jic23@kernel.org>

On Tue,  6 Apr 2021 09:32:44 +0100
Jonathan Cameron <jic23@kernel.org> wrote:

> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> 
> This doesn't appear to generate a warning on all versions of GCC, but
> 0-day reported it and the report looks valid.
> 
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Reported-by: kbuild test robot <lkp@intel.com>

For this one, it's the sort of thing I'd normally just roll into the original
patch, but there is a merge in my tree after this, so in the interests of
simplicity I've applied it on top.

Applied to the togreg branch of iio.git and pushed out as testing for the
autobuilders to take another look at it and see what I got wrong this time :)

Jonathan

> ---
>  drivers/iio/cdc/ad7150.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/cdc/ad7150.c b/drivers/iio/cdc/ad7150.c
> index f9cce1a64586..ebe112b4618b 100644
> --- a/drivers/iio/cdc/ad7150.c
> +++ b/drivers/iio/cdc/ad7150.c
> @@ -235,7 +235,7 @@ static int ad7150_write_event_config(struct iio_dev *indio_dev,
>  				     enum iio_event_direction dir, int state)
>  {
>  	struct ad7150_chip_info *chip = iio_priv(indio_dev);
> -	int ret;
> +	int ret = 0;
>  
>  	/*
>  	 * There is only a single shared control and no on chip


      reply	other threads:[~2021-04-06  8:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-06  8:32 [PATCH] iio:cdc:ad7150: Fix use of uninitialized ret Jonathan Cameron
2021-04-06  8:44 ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210406094405.148dacea@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=lkp@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).