From: Jonathan Cameron <jic23@kernel.org>
To: Sean Nyekjaer <sean@geanix.com>
Cc: linux-iio@vger.kernel.org, andy.shevchenko@gmail.com,
lars@metafoo.de, Nuno.Sa@analog.com, robh+dt@kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2 2/2] dt-bindings: iio: accel: fxls8962af: add bindings
Date: Sat, 24 Apr 2021 11:29:08 +0100 [thread overview]
Message-ID: <20210424112908.2a835f54@jic23-huawei> (raw)
In-Reply-To: <20210423101951.2876009-2-sean@geanix.com>
On Fri, 23 Apr 2021 12:19:51 +0200
Sean Nyekjaer <sean@geanix.com> wrote:
> Add devicetree binding for the NXP FXLS8962AF/FXLS8964AF
> accelerometer sensor.
>
> Signed-off-by: Sean Nyekjaer <sean@geanix.com>
Trivial comment inline, but otherwise looks good to me.
Thanks,
Jonathan
> ---
> Changes for v2:
> - removed requirement for interrupt
>
> .../bindings/iio/accel/nxp,fxls8962af.yaml | 72 +++++++++++++++++++
> 1 file changed, 72 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/accel/nxp,fxls8962af.yaml
>
> diff --git a/Documentation/devicetree/bindings/iio/accel/nxp,fxls8962af.yaml b/Documentation/devicetree/bindings/iio/accel/nxp,fxls8962af.yaml
> new file mode 100644
> index 000000000000..d8ac25402979
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/accel/nxp,fxls8962af.yaml
> @@ -0,0 +1,72 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/accel/nxp,fxls8962af.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: NXP FXLS8962AF/FXLS8964AF Accelerometer driver
> +
> +maintainers:
> + - Sean Nyekjaer <sean@geanix.com>
> +
> +description: |
> + NXP FXLS8962AF/FXLS8964AF Accelerometer driver that supports
> + SPI and I2C interface.
> + https://www.nxp.com/docs/en/data-sheet/FXLS8962AF.pdf
> + https://www.nxp.com/docs/en/data-sheet/FXLS8964AF.pdf
> +
> +properties:
> + compatible:
> + enum:
> + - nxp,fxls8962af
> + - nxp,fxls8964af
> +
> + reg:
> + maxItems: 1
> +
> + vdd-supply:
> + description: phandle to the regulator that provides power to the accelerometer
> +
> + spi-max-frequency: true
> +
> + interrupts:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> + #include <dt-bindings/interrupt-controller/irq.h>
> + i2c0 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + /* Example for a I2C device node */
> + accelerometer@62 {
> + compatible = "nxp,fxls8962af";
> + reg = <0x62>;
> + interrupt-parent = <&gpio0>;
> + interrupts = <0 IRQ_TYPE_LEVEL_HIGH>;
> + };
> + };
> + - |
> + #include <dt-bindings/gpio/gpio.h>
Fair sure we don't need the gpio.h header here though it does
no real harm.
> + #include <dt-bindings/interrupt-controller/irq.h>
> + spi0 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + /* Example for a SPI device node */
> + accelerometer@0 {
> + compatible = "nxp,fxls8962af";
> + reg = <0>;
> + spi-max-frequency = <4000000>;
> + interrupt-parent = <&gpio0>;
> + interrupts = <0 IRQ_TYPE_LEVEL_HIGH>;
> + };
> + };
next prev parent reply other threads:[~2021-04-24 10:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-23 10:19 [PATCH v2 1/2] iio: accel: add support for FXLS8962AF/FXLS8964AF accelerometers Sean Nyekjaer
2021-04-23 10:19 ` [PATCH v2 2/2] dt-bindings: iio: accel: fxls8962af: add bindings Sean Nyekjaer
2021-04-24 10:29 ` Jonathan Cameron [this message]
2021-04-23 12:51 ` [PATCH v2 1/2] iio: accel: add support for FXLS8962AF/FXLS8964AF accelerometers Andy Shevchenko
2021-04-24 10:43 ` Jonathan Cameron
2021-04-27 15:11 ` Sean Nyekjaer
2021-04-27 15:30 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210424112908.2a835f54@jic23-huawei \
--to=jic23@kernel.org \
--cc=Nuno.Sa@analog.com \
--cc=andy.shevchenko@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sean@geanix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).