From: Jonathan Cameron <jic23@kernel.org>
To: Tomasz Duszynski <tomasz.duszynski@octakon.com>
Cc: <linux-iio@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<devicetree@vger.kernel.org>, <lars@metafoo.de>,
<robh+dt@kernel.org>
Subject: Re: [PATCH v3 0/3] iio: sps30: add support for serial interface
Date: Mon, 3 May 2021 11:50:26 +0100 [thread overview]
Message-ID: <20210503115026.06ee3d04@jic23-huawei> (raw)
In-Reply-To: <20210503060014.7632-1-tomasz.duszynski@octakon.com>
On Mon, 3 May 2021 08:00:11 +0200
Tomasz Duszynski <tomasz.duszynski@octakon.com> wrote:
> One can communicate with sensor either over i2c or serial interface.
> This series add support for the latter. And in order to do that existing
> codebase needs to be separated into core and interface specific
> components.
I've taken the view the dt binding change is trivial enough I don't 'need'
to wait for Rob to take a look (though of course any comments are welcome!)
As such, I've applied the series to the togreg branch of iio.git and pushed
it out as testing for the autobuilders to see if we missed anything.
Thanks,
Jonathan
>
> v3:
> - add i2c device matching based on id table
> - constify structure
> - rephrase comment regarding reading serial number
> - check serial number length
>
> v2:
> - simplify Kconfig by hiding core component selection
> - export symbols as GPL compatible
> - drop excessive ops wrappers
> - rework ops to use __be32
> - rework polling for measurements, sensor produces measurements within
> 1s so instead of polling just wait 1s
> - simplify frame ready condition (serial)
> - don't mix char with unsigned version
> - calculate checksum during frame validation (serial)
> - uncomment return status in frame validation (serial)
> - pass part name to probe instead of KBUILD_MODNAME
>
> Tomasz Duszynski (3):
> iio: sps30: separate core and interface specific code
> iio: sps30: add support for serial interface
> dt-bindings: iio: chemical: sps30: update binding with serial example
>
> .../iio/chemical/sensirion,sps30.yaml | 7 +-
> MAINTAINERS | 2 +
> drivers/iio/chemical/Kconfig | 27 +-
> drivers/iio/chemical/Makefile | 2 +
> drivers/iio/chemical/sps30.c | 269 ++---------
> drivers/iio/chemical/sps30.h | 35 ++
> drivers/iio/chemical/sps30_i2c.c | 258 +++++++++++
> drivers/iio/chemical/sps30_serial.c | 431 ++++++++++++++++++
> 8 files changed, 804 insertions(+), 227 deletions(-)
> create mode 100644 drivers/iio/chemical/sps30.h
> create mode 100644 drivers/iio/chemical/sps30_i2c.c
> create mode 100644 drivers/iio/chemical/sps30_serial.c
>
> --
> 2.31.1
>
prev parent reply other threads:[~2021-05-03 10:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-03 6:00 [PATCH v3 0/3] iio: sps30: add support for serial interface Tomasz Duszynski
2021-05-03 6:00 ` [PATCH v3 1/3] iio: sps30: separate core and interface specific code Tomasz Duszynski
2021-05-03 6:00 ` [PATCH v3 2/3] iio: sps30: add support for serial interface Tomasz Duszynski
2021-05-03 6:00 ` [PATCH v3 3/3] dt-bindings: iio: chemical: sps30: update binding with serial example Tomasz Duszynski
2021-05-03 10:50 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210503115026.06ee3d04@jic23-huawei \
--to=jic23@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=tomasz.duszynski@octakon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).