From: Jonathan Cameron <jic23@kernel.org>
To: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
Cc: Fabrice Gasnier <fabrice.gasnier@foss.st.com>,
<linux-iio@vger.kernel.org>,
"Olivier MOYSAN" <olivier.moysan@foss.st.com>
Subject: Re: [PATCH] iio: adc: stm32-adc: Fix docs wrongly marked as kernel-doc
Date: Mon, 3 May 2021 11:52:43 +0100 [thread overview]
Message-ID: <20210503115243.4c2b9c9e@jic23-huawei> (raw)
In-Reply-To: <20210429102253.00004100@Huawei.com>
On Thu, 29 Apr 2021 10:22:53 +0100
Jonathan Cameron <Jonathan.Cameron@Huawei.com> wrote:
> On Thu, 29 Apr 2021 10:16:00 +0200
> Fabrice Gasnier <fabrice.gasnier@foss.st.com> wrote:
>
> > On 4/28/21 9:26 PM, Jonathan Cameron wrote:
> > > From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > >
> > > W=1 highlights these two cases that are obviously not in kernel-doc
> > > format.
> > >
> > > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > > Cc: Fabrice Gasnier <fabrice.gasnier@foss.st.com>
> >
> > Hi Jonathan,
> >
> > I've been a bit surprised but I finally found out the checks have
> > evolved [1].
> > [1] https://lore.kernel.org/linux-next/87pmzlvi0y.fsf@meer.lwn.net/T/
> >
> > It seems it's exposed by commit:
> > 52042e2db452 ("scripts: kernel-doc: validate kernel-doc markup with the
> > actual names")
>
> Good detective work. I wondered why this one hadn't appeared before
> yesterday but was too lazy to check :)
>
> >
> > You can add my:
> > Reviewed-by: Fabrice Gasnier <fabrice.gasnier@foss.st.com>
Applied to the togreg branch of iio.git and pushed out as testing for the
autobuilders to see if we missed anything.
Thanks,
Jonathan
>
> Thanks,
>
> Jonathan
>
> >
> > Thanks,
> > Fabrice
> >
> > > ---
> > > drivers/iio/adc/stm32-adc.c | 4 ++--
> > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/iio/adc/stm32-adc.c b/drivers/iio/adc/stm32-adc.c
> > > index 922af2d75c1e..5088de835bb1 100644
> > > --- a/drivers/iio/adc/stm32-adc.c
> > > +++ b/drivers/iio/adc/stm32-adc.c
> > > @@ -449,7 +449,7 @@ static const struct stm32_adc_regspec stm32h7_adc_regspec = {
> > > .smp_bits = stm32h7_smp_bits,
> > > };
> > >
> > > -/**
> > > +/*
> > > * STM32 ADC registers access routines
> > > * @adc: stm32 adc instance
> > > * @reg: reg offset in adc instance
> > > @@ -851,7 +851,7 @@ static int stm32h7_adc_restore_selfcalib(struct iio_dev *indio_dev)
> > > return 0;
> > > }
> > >
> > > -/**
> > > +/*
> > > * Fixed timeout value for ADC calibration.
> > > * worst cases:
> > > * - low clock frequency
> > >
>
prev parent reply other threads:[~2021-05-03 10:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-28 19:26 [PATCH] iio: adc: stm32-adc: Fix docs wrongly marked as kernel-doc Jonathan Cameron
2021-04-29 8:16 ` Fabrice Gasnier
2021-04-29 9:22 ` Jonathan Cameron
2021-05-03 10:52 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210503115243.4c2b9c9e@jic23-huawei \
--to=jic23@kernel.org \
--cc=Jonathan.Cameron@Huawei.com \
--cc=fabrice.gasnier@foss.st.com \
--cc=linux-iio@vger.kernel.org \
--cc=olivier.moysan@foss.st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).