From: Jonathan Cameron <jic23@kernel.org>
To: <Eugen.Hristev@microchip.com>
Cc: <linux-iio@vger.kernel.org>, <devicetree@vger.kernel.org>,
<Nicolas.Ferre@microchip.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <robh+dt@kernel.org>,
<Ludovic.Desroches@microchip.com>
Subject: Re: [PATCH v3 04/10] iio: adc: at91-sama5d2_adc: convert to platform specific data structures
Date: Sun, 5 Sep 2021 11:24:39 +0100 [thread overview]
Message-ID: <20210905112439.3f90f5dd@jic23-huawei> (raw)
In-Reply-To: <fa9c0d56-7ac5-3ef7-a667-b148ec7b8bb0@microchip.com>
> > @@ -700,9 +786,9 @@ static int at91_adc_read_position(struct at91_adc_state *st, int chan, u16 *val)
> > *val = 0;
> > if (!st->touch_st.touching)
> > return -ENODATA;
> > - if (chan == AT91_SAMA5D2_TOUCH_X_CHAN_IDX)
> > + if (chan == st->soc_info.platform->touch_chan_x)
> > *val = at91_adc_touch_x_pos(st);
> > - else if (chan == AT91_SAMA5D2_TOUCH_Y_CHAN_IDX)
> > + else if (chan == st->soc_info.platform->touch_chan_y)
> > *val = at91_adc_touch_y_pos(st);
> > else
> > return -ENODATA;
> > @@ -715,7 +801,7 @@ static int at91_adc_read_pressure(struct at91_adc_state *st, int chan, u16 *val)
> > *val = 0;
> > if (!st->touch_st.touching)
> > return -ENODATA;
> > - if (chan == AT91_SAMA5D2_TOUCH_P_CHAN_IDX)
> > + if (chan == st->soc_info.platform->touch_chan_y)
>
> Could you please tidy up here before applying, there is a slip on my
> side, it should be the pressure channel :
> if (chan == st->soc_info.platform->touch_chan_p)
>
> (not the Y channel )
>
> Thanks and sorry !
Done
next prev parent reply other threads:[~2021-09-05 10:21 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-01 12:30 [PATCH v3 00/10] iio: adc: at91-sama5d2_adc: add support for sama7g5 Eugen Hristev
2021-09-01 12:30 ` [PATCH v3 01/10] dt-bindings: iio: adc: at91-sama5d2: add compatible for sama7g5-adc Eugen Hristev
2021-09-01 12:30 ` [PATCH v3 02/10] iio: adc: at91-sama5d2_adc: initialize hardware after clock is started Eugen Hristev
2021-09-01 12:30 ` [PATCH v3 03/10] iio: adc: at91-sama5d2_adc: remove unused definition Eugen Hristev
2021-09-01 12:30 ` [PATCH v3 04/10] iio: adc: at91-sama5d2_adc: convert to platform specific data structures Eugen Hristev
2021-09-01 14:31 ` Eugen.Hristev
2021-09-05 10:24 ` Jonathan Cameron [this message]
2021-09-01 12:30 ` [PATCH v3 05/10] iio: adc: at91-sama5d2_adc: add support for separate end of conversion registers Eugen Hristev
2021-09-01 12:30 ` [PATCH v3 06/10] iio: adc: at91-sama5d2_adc: add helper for COR register Eugen Hristev
2021-09-01 12:30 ` [PATCH v3 07/10] iio: adc: at91-sama5d2_adc: add support for sama7g5 device Eugen Hristev
2021-09-01 12:30 ` [PATCH v3 08/10] iio: adc: at91-sama5d2_adc: update copyright and authors information Eugen Hristev
2021-09-01 12:30 ` [PATCH v3 09/10] ARM: dts: at91: sama7g5: add node for the ADC Eugen Hristev
2021-09-15 9:16 ` Nicolas Ferre
2021-09-01 12:30 ` [PATCH v3 10/10] ARM: dts: at91: sama7g5ek: enable ADC on the board Eugen Hristev
2021-09-15 9:17 ` Nicolas Ferre
2021-09-05 10:28 ` [PATCH v3 00/10] iio: adc: at91-sama5d2_adc: add support for sama7g5 Jonathan Cameron
2021-09-15 9:16 ` Nicolas Ferre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210905112439.3f90f5dd@jic23-huawei \
--to=jic23@kernel.org \
--cc=Eugen.Hristev@microchip.com \
--cc=Ludovic.Desroches@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).