From: Jonathan Cameron <jic23@kernel.org>
To: Florian Boor <florian.boor@kernelconcepts.de>
Cc: linux-iio@vger.kernel.org, Jonathan.Cameron@huawei.com,
Michael.Hennerich@analog.com, Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH 2/2] dt-binding: iio: Add documentation for AD799x driver
Date: Sat, 18 Sep 2021 19:25:25 +0100 [thread overview]
Message-ID: <20210918192525.2a0a540e@jic23-huawei> (raw)
In-Reply-To: <20210914145142.138324-2-florian.boor@kernelconcepts.de>
On Tue, 14 Sep 2021 16:51:42 +0200
Florian Boor <florian.boor@kernelconcepts.de> wrote:
Patch title should be dt-bindings: iio: ad779x: Add binding document.
Also, all bindings need to be sent to Rob and the dt mailing list.
Otherwise looks good to me.
Whilst I've +cc'd Rob and device tree lists I don't think patchwork will
pick it up so you should send a v4 (where did version number go on this one)
with them cc'd to be sure it's on their radar.
Thanks,
Jonathan
> New documentation for AD799x series of I²C ADC ICs.
>
> Signed-off-by: Florian Boor <florian.boor@kernelconcepts.de>
> ---
> .../bindings/iio/adc/adi,ad799x.yaml | 67 +++++++++++++++++++
> 1 file changed, 67 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/adc/adi,ad799x.yaml
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad799x.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad799x.yaml
> new file mode 100644
> index 000000000000..66de61050deb
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad799x.yaml
> @@ -0,0 +1,67 @@
> +# SPDX-License-Identifier: GPL-2.0
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/adc/adi,ad799x.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Analog Devices AD7991, AD7992, AD7993, AD7994, AD7995, AD7997, AD7998,
> + AD7999 and similar analog to digital converters
> +
> +maintainers:
> + - Michael Hennerich, Analog Devices Inc. <Michael.Hennerich@analog.com>
> +
> +description: |
> + Specifications on the converters can be found at:
> + AD7991, AD7995, AD7999:
> + https://www.analog.com/media/en/technical-documentation/data-sheets/AD7991_7995_7999.pdf
> + AD7992:
> + https://www.analog.com/media/en/technical-documentation/data-sheets/AD7992.pdf
> + AD7993, AD7994:
> + https://www.analog.com/media/en/technical-documentation/data-sheets/AD7993_7994.pdf
> + AD7997, AD7998:
> + https://www.analog.com/media/en/technical-documentation/data-sheets/AD7997_7998.pdf
> +
> +properties:
> + compatible:
> + enum:
> + - adi,ad7991
> + - adi,ad7992
> + - adi,ad7993
> + - adi,ad7994
> + - adi,ad7995
> + - adi,ad7997
> + - adi,ad7998
> + - adi,ad7999
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + vcc-supply:
> + description:
> + ADC power supply
> +
> + vref-supply:
> + description:
> + ADC reference voltage supply, optional for AD7991, AD7995 and AD7999
> +
> +required:
> + - compatible
> + - reg
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + adc1: ad7991@28 {
> + reg = <0x28>;
> + compatible = "adi,ad7991";
> + interrupts = <13 2>;
> + interrupt-parent = <&gpio6>;
> +
> + vcc-supply = <&vcc_3v3>;
> + vref-supply = <&adc_vref>;
> + };
> +...
next prev parent reply other threads:[~2021-09-18 18:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-14 14:51 [PATCH 1/2] iio: adc: ad799x: Implement selecting external reference voltage input on AD7991, AD7995 and AD7999 Florian Boor
2021-09-14 14:51 ` [PATCH 2/2] dt-binding: iio: Add documentation for AD799x driver Florian Boor
2021-09-18 18:25 ` Jonathan Cameron [this message]
2021-09-18 18:31 ` [PATCH 1/2] iio: adc: ad799x: Implement selecting external reference voltage input on AD7991, AD7995 and AD7999 Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210918192525.2a0a540e@jic23-huawei \
--to=jic23@kernel.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=Michael.Hennerich@analog.com \
--cc=devicetree@vger.kernel.org \
--cc=florian.boor@kernelconcepts.de \
--cc=linux-iio@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).