From: Cai Huoqing <caihuoqing@baidu.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>, <linux-iio@vger.kernel.org>,
<devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v6 1/3] iio: imx8qxp-adc: Add driver support for NXP IMX8QXP ADC
Date: Sun, 26 Sep 2021 21:42:23 +0800 [thread overview]
Message-ID: <20210926134223.GA605@LAPTOP-UKSR4ENP.internal.baidu.com> (raw)
In-Reply-To: <20210926124137.0121a68d@jic23-huawei>
On 26 9月 21 12:41:37, Jonathan Cameron wrote:
> On Sat, 25 Sep 2021 10:05:45 +0800
> Cai Huoqing <caihuoqing@baidu.com> wrote:
>
> > The NXP i.MX 8QuadXPlus SOC has a new ADC IP, so add
> > driver support for this ADC.
> >
> > Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
Hi Jonathan
Thanks for your feedback.
> Hi Cai Huoqing,
>
> Having had a 'final' read through of the driver, I am basically happy
> to merge this after Fabio has had time for another look (plus anyone else
> who wishes to of course!)
>
> There were a few minor things inline though that I'll tidy up whilst applying.
Feel free to fix these directly.
> If you do a v7 for some other reason please sort these out as well.
Sure, if v7 is needed for other issue, I will add these changes BTW.
Many thanks,
Cai
>
> Thanks,
>
> Jonathan
>
> ...
>
> > +#define IMX8QXP_ADR_ADC_TCTRL(tid) (0xc0 + tid * 4)
> > +#define IMX8QXP_ADR_ADC_CMDH(cid) (0x100 + cid * 8)
> > +#define IMX8QXP_ADR_ADC_CMDL(cid) (0x104 + cid * 8)
>
> In macros, it is always a good idea to put brackets around
> any use of parameters so as to avoid potential odd issues
> due to operator precedence.
>
> (0xc0 + (tid) * 4)
>
> > +#define IMX8QXP_ADR_ADC_RESFIFO 0x300
> > +#define IMX8QXP_ADR_ADC_TST 0xffc
>
> ...
>
> > +
> > +struct imx8qxp_adc {
> > + struct device *dev;
> > + void __iomem *regs;
> > + struct clk *clk;
> > + struct clk *ipg_clk;
> > + struct regulator *vref;
> > + struct mutex lock;
>
> A lock should have documentation to identify what it's precise scope is.
> I can add
>
> /* Serialise ADC channel reads */
> above the lock definition whilst applying if you aren't doing a v7 for
> other reasons.
>
> > + struct completion completion;
> > +};
> ...
>
>
> > +
> > +static irqreturn_t imx8qxp_adc_isr(int irq, void *dev_id)
> > +{
> > + struct imx8qxp_adc *adc = dev_id;
> > +
>
> Really minor, but the blank line here doesn't help readability much and
> is inconsistent with the rest of the driver. I might remove this whilst
> applying if nothing else comes up.
>
> > + u32 fifo_count;
> > +
> > + fifo_count = FIELD_GET(IMX8QXP_ADC_FCTRL_FCOUNT_MASK,
> > + readl(adc->regs + IMX8QXP_ADR_ADC_FCTRL));
> > +
> > + if (fifo_count)
> > + complete(&adc->completion);
> > +
> > + return IRQ_HANDLED;
> > +}
> > +
> ...
next prev parent reply other threads:[~2021-09-26 13:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-25 2:05 [PATCH v6 0/3] iio: imx8qxp-adc: Add driver support for NXP IMX8QXP ADC Cai Huoqing
2021-09-25 2:05 ` [PATCH v6 1/3] " Cai Huoqing
2021-09-26 11:41 ` Jonathan Cameron
2021-09-26 13:42 ` Cai Huoqing [this message]
2021-09-26 13:52 ` Fabio Estevam
2021-09-26 14:12 ` Jonathan Cameron
2021-09-25 2:05 ` [PATCH v6 2/3] dt-bindings: iio: adc: Add binding documentation " Cai Huoqing
2021-09-25 2:05 ` [PATCH v6 3/3] MAINTAINERS: Add the driver info of the NXP IMX8QXP Cai Huoqing
2021-09-26 14:16 ` [PATCH v6 0/3] iio: imx8qxp-adc: Add driver support for NXP IMX8QXP ADC Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210926134223.GA605@LAPTOP-UKSR4ENP.internal.baidu.com \
--to=caihuoqing@baidu.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=jic23@kernel.org \
--cc=kernel@pengutronix.de \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).