From: Jonathan Cameron <jic23@kernel.org>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>, linux-iio@vger.kernel.org
Subject: Re: [PATCH] iio: adc: axp288: Override TS pin bias current for some models
Date: Sat, 7 May 2022 15:22:01 +0100 [thread overview]
Message-ID: <20220507152201.6f0af4eb@jic23-huawei> (raw)
In-Reply-To: <20220506095040.21008-1-hdegoede@redhat.com>
On Fri, 6 May 2022 11:50:40 +0200
Hans de Goede <hdegoede@redhat.com> wrote:
> Since commit 9bcf15f75cac ("iio: adc: axp288: Fix TS-pin handling") we
> preserve the bias current set by the firmware at boot. This fixes issues
> we were seeing on various models.
>
> Some models like the Nuvision Solo 10 Draw tablet actually need the
> old hardcoded 80ųA bias current for battery temperature monitoring
> to work properly.
>
> Add a quirk entry for the Nuvision Solo 10 Draw to the DMI quirk table
> to restore setting the bias current to 80ųA on this model.
>
> Fixes: 9bcf15f75cac ("iio: adc: axp288: Fix TS-pin handling")
> BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=215882
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Applied to the fixes-togreg branch of iio.git.
Thanks,
Jonathan
> ---
> drivers/iio/adc/axp288_adc.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/iio/adc/axp288_adc.c b/drivers/iio/adc/axp288_adc.c
> index a4b8be5b8f88..580361bd9849 100644
> --- a/drivers/iio/adc/axp288_adc.c
> +++ b/drivers/iio/adc/axp288_adc.c
> @@ -196,6 +196,14 @@ static const struct dmi_system_id axp288_adc_ts_bias_override[] = {
> },
> .driver_data = (void *)(uintptr_t)AXP288_ADC_TS_BIAS_80UA,
> },
> + {
> + /* Nuvision Solo 10 Draw */
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "TMAX"),
> + DMI_MATCH(DMI_PRODUCT_NAME, "TM101W610L"),
> + },
> + .driver_data = (void *)(uintptr_t)AXP288_ADC_TS_BIAS_80UA,
> + },
> {}
> };
>
next prev parent reply other threads:[~2022-05-07 14:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-06 9:50 [PATCH] iio: adc: axp288: Override TS pin bias current for some models Hans de Goede
2022-05-07 14:22 ` Jonathan Cameron [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-09-15 18:53 Hans de Goede
2019-10-05 10:02 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220507152201.6f0af4eb@jic23-huawei \
--to=jic23@kernel.org \
--cc=hdegoede@redhat.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).