From: Dmitry Rokosov <DDRokosov@sberdevices.ru>
To: "Nuno Sá" <noname.nuno@gmail.com>
Cc: "robh+dt@kernel.org" <robh+dt@kernel.org>,
"jic23@kernel.org" <jic23@kernel.org>,
"lars@metafoo.de" <lars@metafoo.de>,
"andy.shevchenko@gmail.com" <andy.shevchenko@gmail.com>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
kernel <kernel@sberdevices.ru>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1] iio: trigger: warn about non-registered iio trigger getting attempt
Date: Wed, 1 Jun 2022 10:33:46 +0000 [thread overview]
Message-ID: <20220601103356.xlimabcihaay5jky@CAB-WSD-L081021.sigma.sbrf.ru> (raw)
In-Reply-To: <786db9cf74473caef10dcea79975716b5516f47e.camel@gmail.com>
Hi Nuno,
Thank you for comments!
On Wed, Jun 01, 2022 at 10:47:54AM +0200, Nuno Sá wrote:
> On Tue, 2022-05-31 at 18:57 +0000, Dmitry Rokosov wrote:
> > Hi Jonathan,
> >
> > I have one question about a cases when trigger owner is builtin
> > module.
> > In the such cases trig->owner == null, because THIS_MODULE equals to
> > null. How do you think, should we take into account such situations?
> >
> > IMHO we have to take in and save this information to trig_info during
> > trigger allocation call. For example we can check THIS_MODULE from
> > the
>
> Hmmm, If we were to do something during iio_trigger_alloc(), we would
> rather assign already THIS_MODULE to owner and we would not need this
> WARN(). I mean, if someone calls iio_trigger_get() before allocating
> it, it will have bigger problems :).
>
You are right, non-allocated pointer dereference is much bigger problem :)
> I think this could actually be something reasonable...
I think it could be a good solution, but it's required a lot of changes
in the IIO drivers code, because if we assign trig->owner from
iio_trigger_alloc(), we do not need this_mod parameter in the
iio_trigger_register() iface and its wrappers.
So it means to make it workable we must:
- rework iio_trigger_alloc()
- redesign iio_trigger_register() iface and its wrappers
- correct iio_trigger_register() call from all IIO drivers
I suppose we need to wait for Jonathan's comments here...
--
Thank you,
Dmitry
next prev parent reply other threads:[~2022-06-01 10:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-31 18:15 [PATCH v1] iio: trigger: warn about non-registered iio trigger getting attempt Dmitry Rokosov
2022-05-31 18:57 ` Dmitry Rokosov
2022-06-01 8:47 ` Nuno Sá
2022-06-01 10:33 ` Dmitry Rokosov [this message]
2022-06-01 13:09 ` Nuno Sá
2022-06-01 18:03 ` Dmitry Rokosov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220601103356.xlimabcihaay5jky@CAB-WSD-L081021.sigma.sbrf.ru \
--to=ddrokosov@sberdevices.ru \
--cc=andy.shevchenko@gmail.com \
--cc=jic23@kernel.org \
--cc=kernel@sberdevices.ru \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=noname.nuno@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).